Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backstage.taboola.com #182230

Closed
adguard-bot opened this issue Jun 25, 2024 · 4 comments
Closed

backstage.taboola.com #182230

adguard-bot opened this issue Jun 25, 2024 · 4 comments
Assignees
Labels
A: In progress Work on the issue is in progress A: Waiting for data Waiting for more information from the user N: AdGuard Browser Extension P1: Critical T: Incorrect Blocking

Comments

@adguard-bot
Copy link

Issue URL (Incorrect Blocking)

https://backstage.taboola.com/backstage/1670999/reports#%7B%22id%22%3A%22kvhet9ppirzh%22%2C%22groupId%22%3A%22performance%22%2C%22reportId%22%3A%22guarantee-revenue%22%2C%22dateRangeSelector%22%3A%7B%22id%22%3A%221%22%2C%22term%22%3A%22this%20day%22%2C%22range%22%3A0%2C%22dateStart%22%3A%222024-06-25%22%2C%22dateEnd%22%3A%222024-06-25%22%7D%2C%22queryFilter%22%3A%5B%7B%22id%22%3A%22composed_placement_page_type%22%2C%22operator%22%3A%22equal%22%2C%22value%22%3A%22-1%22%7D%5D%2C%22currentDimension%22%3A%7B%22tab%22%3A%22tab-day%22%2C%22pages%22%3A%5B%7B%22dim%22%3A%22performance%2Fguarantee-revenue%2Fday%22%2C%22table%22%3A%7B%22key%22%3A%22date%22%2C%22order%22%3A%22desc%22%2C%22page%22%3A1%7D%2C%22legend%22%3A%22000000000001%22%7D%2C%7B%22dim%22%3A%22performance%2Fguarantee-revenue%2Fweek%22%2C%22table%22%3A%7B%22key%22%3A%22date%22%2C%22order%22%3A%22desc%22%2C%22page%22%3A1%7D%2C%22legend%22%3A%22000000000001%22%7D%2C%7B%22dim%22%3A%22performance%2Fguarantee-revenue%2Fmonth%22%2C%22table%22%3A%7B%22key%22%3A%22date%22%2C%22order%22%3A%22desc%22%2C%22page%22%3A1%7D%2C%22legend%22%3A%22000000000001%22%7D%2C%7B%22dim%22%3A%22performance%2Fguarantee-revenue%2Fpage_type_breakdown%22%2C%22table%22%3A%7B%22key%22%3A%22placement%22%2C%22order%22%3A%22asc%22%2C%22page%22%3A1%7D%2C%22legend%22%3A%22000000000001%22%7D%2C%7B%22dim%22%3A%22performance%2Fguarantee-revenue%2Fsub_placement_breakdown%22%2C%22table%22%3A%7B%22key%22%3A%22placement%22%2C%22order%22%3A%22asc%22%2C%22page%22%3A1%7D%2C%22legend%22%3A%220000000000010%22%7D%2C%7B%22dim%22%3A%22performance%2Fguarantee-revenue%2Fpage_type_and_sub_placement_breakdown%22%2C%22table%22%3A%7B%22key%22%3A%22placement%22%2C%22order%22%3A%22asc%22%2C%22page%22%3A1%7D%2C%22legend%22%3A%220000000000010%22%7D%2C%7B%22dim%22%3A%22performance%2Fguarantee-revenue%2Fcountry_breakdown%22%2C%22table%22%3A%7B%22key%22%3A%22page_views%22%2C%22order%22%3A%22desc%22%2C%22page%22%3A1%7D%2C%22legend%22%3A%22000000000001%22%7D%2C%7B%22dim%22%3A%22performance%2Fguarantee-revenue%2Fplatform_breakdown%22%2C%22table%22%3A%7B%22key%22%3A%22page_views%22%2C%22order%22%3A%22desc%22%2C%22page%22%3A1%7D%2C%22legend%22%3A%22000000000001%22%7D%2C%7B%22dim%22%3A%22performance%2Fguarantee-revenue%2Fsegment_breakdown%22%2C%22table%22%3A%7B%22key%22%3A%22segment%22%2C%22order%22%3A%22asc%22%2C%22page%22%3A1%7D%2C%22legend%22%3A%22000000000001%22%7D%5D%7D%7D

Comment

When using the admin panel of Taboola, a specific URL fails to load if AdGuard's language filters are enabled, even when AdGuard is disabled for the website. This issue breaks the website and prevents the report from being generated.

AdGuard Status:
AdGuard is disabled for the website.
Language-specific filters in AdGuard are enabled.
Problem:
With language-specific filters enabled, the URL request gets blocked before it executes, causing the website to break and the report generation to fail.
When language filters are turned off, the URL loads successfully, and the network request executes correctly.

Steps to Reproduce:
You can't reproduce it, but I'm explaining.
Disable AdGuard for the Taboola admin panel website.
Ensure language filters in AdGuard are enabled.
In the network panel URL request gets blocked, breaking the website and preventing report generation.
Disable the language filters in AdGuard.
Attempt to load the URL again and observe that it loads successfully.

Expected Behavior:
The URL should load successfully, and the report should generate correctly even if the language filters are enabled, given that AdGuard is disabled for the website.

URL: https://backstage.taboola.com/backstage/resources/components/requirejs/require.js
Username: @Chetan7575

Screenshots

Screenshot 1

Screenshot 1

Screenshot 1 with AdGuard disabled

Screenshot 1

System configuration

Information Value
AdGuard product: AdGuard Browser Extension v4.3.53
System version: Windows 10
Browser: Chrome
Stealth mode options: Strip URLs from tracking parameters,
Hide your search queries,
Send Do-Not-Track header,
Remove X-Client-Data header from HTTP requests,
Self-destructing third-party cookies (2880)
Filters: Ad Blocking:
AdGuard Base,
EasyList

Privacy:
AdGuard URL Tracking

Annoyances:
AdGuard Annoyances,
AdGuard Popups,
Fanboy's Annoyances,
Adblock Warning Removal List

Security:
Online Malicious URL Blocklist,
Phishing URL Blocklist,
Scam Blocklist by DurableNapkin,
uBlock Origin – Badware risks

Other:
Filter unblocking search ads and self-promotion
@jellizaveta
Copy link
Contributor

jellizaveta commented Jun 26, 2024

@Chetan7575 Hi there! Could you please enable only AdGuard filters and check the page without any third party filters? As I recall, EasyList Thailand blocks ||taboola.com^ and it may cause this problem. But if this site is broken by third party filter, we cannot fix it directly, I can suggest user rule (something like ||taboola.com^$badfilter) or report this issue to maintainer.

@jellizaveta jellizaveta added the A: Waiting for data Waiting for more information from the user label Jun 26, 2024
@Chetan7575
Copy link

@jellizaveta Yes, I tried, in language-specific filters I stopped EasyList Thailand and the report started showing.

But as I disabled Adguard on the website, so its filters should not be applied. However, I noticed that the filters were still active, particularly the Thailand one. I want to understand why this is happening despite Adguard being disabled for the specific website. Could you please explain this to me? Thank you.

And I have not activated EasyList Thailand. In language-specific, these filters become active automatically when we browse some sites.

@jellizaveta
Copy link
Contributor

@Chetan7575

In AdGuard, there is a setting activate the most appropriate filters automatically — it enables the most appropriate filters for the language of the site automatically. If you disable it, the filters will not be automatically activated.

Screenshot: Screenshot 2024-06-27 at 2 51 32 PM

@jellizaveta
Copy link
Contributor

If you switch off AdGuard, the page needs to reload so that the blocker stops applying the rules. If after several page reloads you still have AdGuard running, please report a bug in this repository: https://github.com/AdguardTeam/AdguardBrowserExtension

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: In progress Work on the issue is in progress A: Waiting for data Waiting for more information from the user N: AdGuard Browser Extension P1: Critical T: Incorrect Blocking
Projects
None yet
Development

No branches or pull requests

3 participants