discordapp.com

[DandelionSprout]

Description:

The entry ##iframe[width="240"][height="300"] in AdGuard Base Filter is under certain circumstances causing embedded Twitter videos to fail to show up or to be played.

• Current behaviour:

The video fails to play back, and instead turns to grey with no sound once its thumbnail is clicked on.

Screenshot:

• Expected behaviour:

The video is correctly played back.

Screenshot:

Steps to reproduce the problem:

1. Post a link in any Discord server (except those that have turned off link embeds entirely), to a tweet that has a video in ~4:5 aspect ratio. For instance https://twitter.com/HoIdMyBeaker/status/1178329459876712453.
2. Make sure you've turned on the Discord setting that shows link previews/embeds.
3. Click on the embed.
4. See that it turns to a grey still image.

System configuration

Filters:

Information	Value
Operating system:	Windows 10
Operating system version (Android/iOS)
Browser:	Google Chrome 77 64-bit
AdGuard version:	Nano Adblocker 1.0.0.127 + Nano Defender 15.0.0.168
Filters enabled:	See screenshot of Nano Adblocker settings above.
AdGuard mode (Android only):
Filtering quality (Android only):
HTTPS filtering (Android only):
Simplified filters (iOS only)
AdGuard DNS:	None
Stealth mode options (Windows only)	None
Helpdesk ID (if exists):

[krystian3w]

@@||twitter.com^$generichide works? Or this is "about:blank" iframes: uBlockOrigin/uBlock-issues#688

[DandelionSprout]

In my eyes, the problem is simply about Twitter video embeds that use very specific sizing and size-related element values. It doesn't seem to be any more complicated than that.

[DandelionSprout]

So @@||twitter.com^$generichide has no effect on it, and I'm currently presuming the fix would be ~discordapp.com##iframe[width="240"][height="300"] or something very similar.

[krystian3w]

Strange...

AdguardFilters/EnglishFilter/sections/banner_sizes.txt

Line 56 in e09034d

##iframe[width="240"][height="300"]

@@||discordapp.com^$generichide

or (maybe invalid...):

@@||discordapp.com^$generichide,domain=twitter.com

[DandelionSprout]

@@||discordapp.com^$generichide does work, but seems very drastic to me, so I'd reserve it as a plan B.

@@||discordapp.com^$generichide,domain=twitter.com unfortunately doesn't work.

[krystian3w]

Why, discord in my logger no have any filters to block network or hide elements (so no have tracking / ads).

[DandelionSprout]

That is true. Discord is pretty kind by having no tracking and almost no ads.

But this is only really the 2nd generic-entry-related problem I've come across on Discord after being there for 6 months (The 1st being uBlockOrigin/uAssets#5883), so at the current point in time I think the amount of individual problems are few enough that they can be dealt with individually.

[AdamWr]

Fixed, thank you.