Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google.com #87920

Closed
seba2282 opened this issue Jul 8, 2021 · 13 comments
Closed

google.com #87920

seba2282 opened this issue Jul 8, 2021 · 13 comments

Comments

@seba2282
Copy link

seba2282 commented Jul 8, 2021

google.com when I write example in search "cosik" and click that link: https://pl.m.wiktionary.org/wiki/cosik then:

with filter Adguard url protect tracking have that
Screenshot_2021-07-08-23-04-35.png

When filter url protect tracking is turned off, then normally go on site

Screenshot_2021-07-08-23-05-20.png

with www google.pl any problems.

I see actually that in Firefox on Android. I don't know how is with PC because I didn't test

@krystian3w
Copy link
Contributor

I see this and may help:

https://addons.mozilla.org/pl/android/addon/google-search-fixer/

@krystian3w
Copy link
Contributor

For uBO 1.36.0+ works:

@@||google.*/url?q=*&ved=*&usg=*$queryprune,domain=google.*

@seba2282
Copy link
Author

seba2282 commented Jul 9, 2021

For uBO 1.36.0+ works:

@@||google.*/url?q=*&ved=*&usg=*$queryprune,domain=google.*

It work, @krystian3w

@krystian3w

This comment has been minimized.

@BlazDT
Copy link
Contributor

BlazDT commented Jul 9, 2021

Thank you. Disabled that two.

@garry-ut99
Copy link

garry-ut99 commented Feb 17, 2024

Alex-302 : 293a7d9#r53256922 : Why disabled? I can't reproduce this issue?
Alex-302 : 293a7d9#r53288717 : I don't see any issues with this rule.

I can still reproduce on Mobile after you bringed back the rule in fe5a4d2,
also another your rule causes it too: 2d1ca89 , these filters cause it:
||google.*/search$removeparam=ved
||google.*/search$removeparam=sa

Also more info in these threads:

That redirect notice appearing every 2nd link clicked by an user in Mobile Google search results is really annoying,
also what makes it even more painful is a fact that the redirect notice and link are written in a very small font which is hard to see and click on Mobile.


seba2282 : #87920 (comment) :

For uBO 1.36.0+ works:

`@@||google.*/url?q=*&ved=*&usg=*$queryprune,domain=google.*`

It work.

Works for me too, but I've fine-tuned it a bit:
@@||google.*/url?q=*&sa=*&ved=*&usg=*$removeparam,domain=google.*
I will see how it works in a long term, because it need to be tested whether all the 3 params are always present together, if not then will need to split the filter into 2 or 3 separate filtes or convert to a regex rule.

By the way, a similiar exception was added to Legitimate URL Shortener :

@seba2282
Copy link
Author

Good know that :)

@Alex-302
Copy link
Member

@garry-ut99 I don't see any problems.
Please write steps to reproduce (better sent a new report using feedback menu in AdGuard - all your settings will be loaded).

@garry-ut99
Copy link

garry-ut99 commented Feb 19, 2024

On Firefox Mobile + AdGuard Browser Ext or uBlock Origin + AdGuard URL Tracking Protection list enabled :

  1. Search some phrases in Google search, for example: "wallpapers" or "car photos"
  2. Then click some links in the results, for example: "www.pexels.com" or "pixabay.com"
  3. Notice you're landing on Google redirect page with "Redirect warning"

The issue doesn't appear on all links, but on some of them, sometimes even every 2nd or 3rd link - depends on a phrase, averagely often enought to be considered a big annoyance, so either a whiltelist should be added, or a scriptlet to defuse Google link scanner script.

@Alex-302
Copy link
Member

Can't reproduce. Not sure if it's necessary to change the filters.

@garry-ut99
Copy link

garry-ut99 commented Feb 19, 2024

This f...ing "can't reproduce" / I don't see problems" is quite annoying.
Ok, what is your device / user-agent you are unable to reproduce on,
I'm asking because the reproducibility depends on it, just like in the initial comment :

seba2282 : I see actually that in Firefox on Android. I don't know how is with PC because I didn't test

It can be reproduced only on Android real smartphone, neither in iPhone/iPad, nor in Firefox Responsive Design Mode (which sets some unusual / odd user-agents), (unless manually changed/forced a different user-agent) and even in Android sometimes not reproduce on some user-agent string.

Example device/user-agent string I can reproduce on:
Mozilla/5.0 (Android 13; Mobile; rv:122.0) Gecko/122.0 Firefox/122.0
(version of Android can be changed, also Mobile can be replaced with Tablet,
and I still can reproduce, Google script relies on some values/strings in user-agent,
and redirection depends on it)

@Alex-302
Copy link
Member

It can be reproduced only on Android real smartphone, neither in iPhone/iPad, nor in Firefox Responsive Design Mode (which sets some unusual / odd user-agents), (unless manually changed/forced a different user-agent) and even in Android sometimes not reproduce on some user-agent string.

I don't use emulation mode, only real devices.

This f...ing "can't reproduce" / I don't see problems" is quite annoying.
Ok, what is your device / user-agent you are unable to reproduce on,

You're not the only Firefox Mobile user with a browser extension. There are no other complaints. I assume that the problem is also related to some browser settings. I have two Android devices, and all good.

@garry-ut99
Copy link

garry-ut99 commented Feb 20, 2024

You're not the only Firefox Mobile user with a browser extension. There are no other complaints.

Crappy answer, as if you were blind and didn't notice that OP reported same issue (just with a different phrase put in Google search and a different link which can't be reproduced now anymore) and BlazDT fixed it for OP, because BlazDT noticed the issue, but you didn't see any problem and added the filters again, and now you bringed the issue back for me, and you're saying again you don't see any problem.

I have two Android devices, and all good.

What does this shitty answer "all good" mean?
Did you try to reproduce on my user-agent string or not?

I assume that the problem is also related to some browser settings.

Yes, like I already said: reproducility depends on user-agent.

Could you be more helpful in reproducing the issue..., I provided you my user-agent string in my previous comment, because I expected you to copy it and set the same user-agent in your browser and tell me whether you can reproduce the issue with my user-agent . Also I asked you what is your device/user-agent so that I can check whether I can reproduce the issue on my end with your user-agent string.

Custom user-agent string can be set in https://firefox-source-docs.mozilla.org/devtools-user/responsive_design_mode/ or alternatively can use one of plenty extensions in Firefox Desktop to set custom user-agent, for example https://addons.mozilla.org/pl/firefox/addon/uaswitcher/ , I don't see any extension for Firefox Mobile, but the issue can be reproduced on Firefox Desktop with custom user-agent string anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants