Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pixiv.net cookie notices and infinite reload due to rules conflict #178389

Merged
merged 1 commit into from
May 5, 2024

Conversation

JasonKhew96
Copy link
Contributor

Prerequisites

To avoid invalid pull requests, please check and confirm following terms

  • This is not an ad/bug report;
  • My code follows the guidelines and syntax of this project;
  • I have performed a self-review of my own changes;
  • My changes do not break web sites, apps and files structure.

What problem does the pull request fix?

If the problem does not fall under any category that is listed here, please write a comment below in corresponding section

  • Missed ads or ad leftovers;
  • Website or app doesn't work properly;
  • AdGuard gets detected on a website;
  • Missed analytics or tracker;
  • Social media buttons — share, like, tweet, etc;
  • Annoyances — pop-ups, cookie warnings, etc;
  • Filters maintenance.

What issue is being fixed?

  • fix pixiv.net cookie notices rule, the cookie value should be 6
  • fix infinite reload if enabled with EasyList - Cookie Notices since this filter set cookie value to 5 and EasyList - Cookie Notices set cookie value to 6

Terms

  • By submitting this issue, I agree that pull request does not contain private info and all conditions are met

also fix infinite reload if enabled with `EasyList - Cookie Notices` since this filter set cookie value `5` and `EasyList - Cookie Notices` set cookie value `6`
@Yuki2718
Copy link
Collaborator

Yuki2718 commented May 4, 2024

@Alex-302 Hard breakage on a very popular site, it's not something to be left for days.

@Yuki2718 Yuki2718 mentioned this pull request May 4, 2024
@AdamWr AdamWr merged commit 9bb7c00 into AdguardTeam:master May 5, 2024
2 checks passed
@JasonKhew96 JasonKhew96 deleted the fix-pixiv-net branch May 5, 2024 08:42
@jackrjli
Copy link

jackrjli commented May 5, 2024

This breakage will happen again if Pixiv changes the cookie value (which I guess they do when they update their privacy policy and need to notify everyone again) and the lists update to reflect that. I wonder whether it is necessary to set the cookie at all, since even without this rule the privacy policy update banner is hidden by a cosmetic filter:

pixiv.net##div > div:not([class]) > div[class^="sc-"]:has(> div > p > span > a[href^="https://policies.pixiv.net"])

pixiv.net#?#div > div:not([class]) > div[class^="sc-"]:has(> div > p > span > a[href^="https://policies.pixiv.net"])

@krystian3w
Copy link
Contributor

krystian3w commented May 5, 2024

If can by hidden instead rewrite to trusted-click-element (if button are stable).

@AtomicLugia
Copy link

Pixiv is at it again, the filter doesn't work anymore, infinite reload is back

@Yuki2718
Copy link
Collaborator

Pixiv is at it again, the filter doesn't work anymore, infinite reload is back

I can't reproduce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants