Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amazon version and update channels #102

Closed
ameshkov opened this issue Oct 16, 2015 · 43 comments
Closed

Amazon version and update channels #102

ameshkov opened this issue Oct 16, 2015 · 43 comments
Assignees
Labels
Bug
Milestone

Comments

@ameshkov
Copy link
Member

@ameshkov ameshkov commented Oct 16, 2015

There should not be any update channel for Amazon version of Adguard. All versions should use release channel.

All updates should be handled by Amazon app.

@ameshkov ameshkov added the Bug label Oct 16, 2015
@ameshkov ameshkov added this to the 2.1 patch milestone Oct 16, 2015
@TPS

This comment has been minimized.

Copy link
Contributor

@TPS TPS commented Oct 17, 2015

As I mentioned earlier, Amazon seems to treat the beta as a separate app (sort of). Is it possible, then, to have official release OR beta release installed, then you folks push appropriate updates to each, & let Amazon handle the updating? I certainly like the opportunity to be on bleeding edge, & it sure would help with debugging the various codebase differences.

@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Oct 19, 2015

I doubt you'll be able to install beta and release versions along on one device.

Is it possible, then, to have official release OR beta release installed, then you folks push appropriate updates to each, & let Amazon handle the updating

Yep, that's what we'd like to to do.

@TPS

This comment has been minimized.

Copy link
Contributor

@TPS TPS commented Oct 19, 2015

Nono, I mean a user would choose 1 or the other (given appropriate invites from you all ;), & then either would handled independently — more or less how a user chooses to flip that beta/release toggle for the website version.

I'd happily reinstall the "Test" version if I got invites to updates at same time as beta website versions. But the lag between 1 & the other defeats that purpose, right?

@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Oct 19, 2015

I'd happily reinstall the "Test" version if I got invites to updates at same time as beta website versions. But the lag between 1 & the other defeats that purpose, right?

The main problem here is that we don't yet push Test versions along with website beta release. But that's not intentional, just need some time to get used to amazon:)

@Revertron

This comment has been minimized.

Copy link
Member

@Revertron Revertron commented Oct 20, 2015

Hid the channels for amazon builds.

@Revertron Revertron closed this Oct 20, 2015
@TPS

This comment has been minimized.

Copy link
Contributor

@TPS TPS commented Oct 21, 2015

@ameshkov @Revertron Thanks for the updated test invite! I've updated to it & (as a bonus 😉) ran into a complicated point 5 in my odd notes. ☺

@TPS

This comment has been minimized.

Copy link
Contributor

@TPS TPS commented Oct 26, 2015

@ameshkov @Revertron The test build is < the current release update I'm getting prompted for: .231 vs .240. Also, I've not received any test builds in between.…

@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Oct 26, 2015

@TPS .240 is a new release, there were no tests between RC and actual release.

@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Oct 26, 2015

Hm, wait, you've got that notification on amazon version right?

Maybe we should have disabled notifications also..

@Revertron what do you think?

@TPS

This comment has been minimized.

Copy link
Contributor

@TPS TPS commented Oct 26, 2015

@ameshkov @Revertron Notifications are fine, but then you gotta remember to keep test ≥ release by keeping both updated & sending test invites. When I receive the notification to update from test to release, I do have to report something's a bit off, right? Or do you see this differently than I do? (I see this conceptually, e.g., how NoScript's dev build rolls out: the last dev build before a release build is practically identical except for the logic to keep on the dev update mechanism. Is it meant to be same here?)

@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Oct 26, 2015

We have pushed .240 to stable in Amazon, it just takes some time to go through review process.

@Revertron I still think we should ignore update info until "forced" flag isn't true.

@ameshkov ameshkov reopened this Oct 26, 2015
@TPS

This comment has been minimized.

Copy link
Contributor

@TPS TPS commented Oct 27, 2015

.240 is live on Amazon, just not on testing build. The latest there is .231, I think, but since they're interrelated on Amazon's backend, one will update the other with strange side effects.

@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Oct 29, 2015

Is it possible to somehow disable test build when you update to newer stable?

@TPS

This comment has been minimized.

Copy link
Contributor

@TPS TPS commented Oct 29, 2015

Other than overwrite via update, or uninstall/reinstall, I don't see how.… I'm not sure what you mean?

@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Oct 29, 2015

I mean disable test build in amazon underground

@TPS

This comment has been minimized.

Copy link
Contributor

@TPS TPS commented Oct 29, 2015

I'm not running Underground, just plain Appstore; disable what, again?

@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Oct 29, 2015

There was an Appstore app?:) I've always though they have replaced it with Underground:)

@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Oct 29, 2015

Ok, I mean you have "test build" in your apps list.
Could you simply remove it from the list?

@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Oct 29, 2015

As test and prod are separate build this will fix the update issue.
And when new test build is ready you can remove the stable one.

@TPS

This comment has been minimized.

Copy link
Contributor

@TPS TPS commented Oct 29, 2015

Underground is a replacement for the Google release of the regular Amazon (shopping) app, but to successfully run Amazon-bought apps, 1 must run Appstore, also. They complement each other (if you want them both), but don't completely overlap functionally.

Test & release are separate builds, but, as mentioned, 1 overwrites the other & licensing is entirely separate. That's why I was hoping that everything release would be also published test, though not other way around.

@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Oct 29, 2015

That's rather hard to do:)

The only way to change this once and forever is to have different beta and release package names.
Then we can even have public "beta" app on amazon.

@TPS

This comment has been minimized.

Copy link
Contributor

@TPS TPS commented Oct 29, 2015

I'm missing something. Is this an Amazon restriction to not allow 2 identical apps to be published simultaneously? Else, I'm thinking it's simple to have a release published under each ASIN simultaneously.…

@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Oct 29, 2015

It always take some time for them to review&publish new version.

Also every new test build is a real pain, you have to create new test manually, select testers, select devices, wait until binary is checked and such.

I mean really, publishing new stable version is easier than this:)

@TPS

This comment has been minimized.

Copy link
Contributor

@TPS TPS commented Oct 29, 2015

You'd think they'd make it easier for a test, which, after all, is opt-in, so testers are willing for risk, anyway.

I read there will be an urgent update soon, so I'll wait to see how it's released & do that, probably.

@TPS

This comment has been minimized.

Copy link
Contributor

@TPS TPS commented Oct 30, 2015

@ameshkov @Revertron Thanks for the tester invite to .240+! (I've lost track of how many invites.… ☺) I think I've found an Appstore snafu, so am in contact with them about it. As soon as that gets resolved, I'll install & get on our way. 😃

Update: Is anyone else reporting not be able to update to new test versions? Or am I an isolated case? 😕

Fixed!: This is just #98 (comment), so fixed by disabling AG temporarily until update, then re-enabling. ☺

@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Nov 3, 2015

Disabled app update check for amazon build. With the current scheme it is too confusing.

@ameshkov ameshkov closed this Nov 3, 2015
@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Nov 3, 2015

@TPS i have pushed new release (2.1.267) to test in Amazon.

Could you please take a look at it once it is available?
If it's ok I will also push it to stable.

@TPS

This comment has been minimized.

Copy link
Contributor

@TPS TPS commented Nov 3, 2015

@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Nov 3, 2015

Test is submitted, I guess we should simply wait now

@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Nov 3, 2015

@TPS as I see in Amazon interface test update is available.

Now I've added this test properly and there is no need in re-inviting you:)

@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Nov 5, 2015

@TPS so how is the new test build? Can we push it to release?

@TPS

This comment has been minimized.

Copy link
Contributor

@TPS TPS commented Nov 5, 2015

@ameshkov Other than #98 (comment) , looks great (& the new test releas_ing_ worked perfectly!)

@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Nov 5, 2015

Thank you!:) Pushing it then.

@TPS

This comment has been minimized.

Copy link
Contributor

@TPS TPS commented Dec 9, 2015

@ameshkov For the many recently closed issues, I've received no beta updates, not through Amazon nor directly (I run 1 each, as you may remember). Have none actually been released? I seem to remember a beta being mentioned in 1 of the recently completed issues.…

@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Dec 9, 2015

@TPS, we are closing the issue when it's fixed in the code, it is not tied to a release.

But your question is just in time, new beta has just arrived:
https://github.com/AdguardTeam/AdguardForAndroid/releases/tag/2.1.319

Should be available through amazon soon, now it is in "Publishing" status.

@TPS

This comment has been minimized.

Copy link
Contributor

@TPS TPS commented Dec 10, 2015

Got both, thanks!

@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Dec 10, 2015

@TPS btw, how do you check for Amazon updates?

Does appstore updates the app automatically or do you check invite link every time?

Here is a thread on our forum when one of beta testers has some issues with getting new beta via amazon:
http://forum.adguard.com/showthread.php?8074-Adguard-for-Android-Beta-version-2-1-319

@TPS

This comment has been minimized.

Copy link
Contributor

@TPS TPS commented Dec 10, 2015

I use Appstore app to check updates via "My Apps" → Refresh or simply just go to app listing. The update notified there after several hours, even after I got Amazon e-mail notification & the website version did (as you predicted). That's just Amazon being slow, I think. Have your forum Amazon beta folks try now; if they can't get it, though I have, have them contact Amazon customer service.

I also always disable AG before updating Play, which I usually do concurrently to Appstore, so maybe that's a factor.

@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Dec 11, 2015

@TPS thank you! I think it's just Amazon is slow indeed, let's see what happens with the next beta.

@TPS

This comment has been minimized.

Copy link
Contributor

@TPS TPS commented Jan 12, 2016

I notice you're updating the changelog on Amazon for the release builds. Would it be possible to do the same for the test builds? I'd sure like to know what changed, so I can test it! (Though I guess I could just read https://github.com/AdguardTeam/AdguardForAndroid/releases, huh? ;)

(Just received the Amazon notification for a new test, but Appstore hasn't caught up yet took 45 minutes to update. YMMV.)

@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Jan 12, 2016

There's no such field there.

Yet there is a field named "What to test", we usually put changelog there.

@TPS

This comment has been minimized.

Copy link
Contributor

@TPS TPS commented Jan 13, 2016

I'm confused.… Do you run the latest Appstore app? Each app has 2 tabs now where there used to be just "Description"; the other is "Release Notes." (On the website, it's a section called "Latest Updates: What's new in version" x.xx.) You all have been using "Release Notes" (aptly) for that release's changelog, though only for the release build (http://smile.amazon.com/dp/B0158CTKR8), but not yet the test (http://smile.amazon.com/dp/B0158CTQ2C).

I actually have never knowingly seen the field "What to test" nor its contents.… Where does it appear?

@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Jan 13, 2016

Frankly I don't know, I see it in developer's interface only. Very amazon i must say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.