Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about non-filtered connections to the filtering log #1730

Closed
ameshkov opened this issue Feb 22, 2018 · 9 comments
Closed

Add information about non-filtered connections to the filtering log #1730

ameshkov opened this issue Feb 22, 2018 · 9 comments
Assignees
Milestone

Comments

@ameshkov
Copy link
Member

At the moment we're completely ignoring some connections:

  • Connections that are blocked by the firewall rules;
  • Connections that are not bypassed on the VPN level for some reason;

We should record them as a "Tunnel" event type.

@TPS
Copy link
Contributor

TPS commented Apr 10, 2018

Can they also be highlighted w/ another color(s) in the filtering log, & added to #1369 (or similar)?

@ameshkov
Copy link
Member Author

@admitrevskiy one more thing is missing from the implementation.

We need to be able to construct blocking (and unblocking) rules for this kind of connections. It is possible to block or unblock a network connection with the rules that use the $network modifier.

@Alex-302
Copy link
Member

Alex-302 commented May 14, 2018

IP is displayed instead of host name(it seems in VPN mode)
image

@ameshkov
Copy link
Member Author

IP is displayed instead of host name(it seems in VPN mode)

Yes, that's expected -- no filtering, no parsing connection details.

@zebrum
Copy link
Member

zebrum commented Jul 25, 2018

seems to be not working.

@ameshkov
Copy link
Member Author

ameshkov commented Jul 25, 2018

@zebrum testing instructions:

  1. Disable ad blocking for Chrome
  2. Open some web page
  3. Check the filtering log

@zebrum
Copy link
Member

zebrum commented Jul 26, 2018

@ameshkov yep, that's exactly what I've done.

@vozersky
Copy link
Member

Connections that are not bypassed on the VPN are shown in the log, but connections that are blocked by the firewall rules are not

@ameshkov
Copy link
Member Author

Resolved in adguard-android/pull-requests/573

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants