Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use protection startup timeout when the VpnService requires preparation #1934

Closed
ameshkov opened this issue Jun 25, 2018 · 1 comment
Assignees
Milestone

Comments

@ameshkov
Copy link
Member

It can take quite some time for a user to read what's in the dialog so we must not crash the app while he or she is reading.

@ameshkov ameshkov added this to the 2.12 milestone Jun 25, 2018
@ameshkov ameshkov self-assigned this Jun 25, 2018
@ameshkov
Copy link
Member Author

ameshkov commented Jun 26, 2018

Resolved.

Testing instructions:

  1. Reinstall AdGuard
  2. Try starting protection
  3. When AdGuard shows a VPN access dialog, do nothing for 60+ seconds

Expected result:
Nothing happens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants