Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New DNS module settings UI #2145

Closed
ameshkov opened this issue Sep 26, 2018 · 5 comments
Closed

New DNS module settings UI #2145

ameshkov opened this issue Sep 26, 2018 · 5 comments
Assignees
Milestone

Comments

@ameshkov
Copy link
Member

See the sketch file in slack

@AlikhanAliev
Copy link

@admitrevskiy
Copy link

Resolved.

Testing instructions for QA:
-Add any custom server
-Choose any pre-defined server
-Reinstall AG
-Examine new DNS module

Expected result:
-Custom server is in My DNS servers list
-If pre-defined server is not AG/Google/Cloudflare/OpenDNS/Quad9 (quad9-dns/quad9-dnscrypt-ip4-filter-pri/quad9-dnscrypt-ip6-filter-pri/quad9-doh-ip4-filter-pri/quad9-doh-ip6-filter-pri): Selected server is in My DNS servers list
-Otherwise: The appropriate provider is selected

@ameshkov
Copy link
Member Author

ameshkov commented Dec 7, 2018

@admitrevskiy there are more changes required.

  1. DNS --> DNS Filtering

  2. Description in the settings section: DNS filtering settings

  3. "Choose DNS server from list" --> Choose from a list

    Click on the "choose" button should lead to a page on the knowledge base with a list of known DNS services. Task for the KB page: Add a "Known DNS Providers" page AdguardKnowledgeBase#272

  4. Intercept sdns:// protocol links and open the "Enter DNS Server" dialog in AdGuard.

@admitrevskiy
Copy link

Resolved,

Testing instructions:
-Reinstall AG
-Go to Custom DNS Settings
-Tap on Choose DNS server from the list should lead to KB article about popular DNS providers (https://kb.adguard.com/ru/general/dns-providers) via browser.
-Select any server from list in the article and click on Add to AdGuard

Expected result:
-AG opens "Add new server" dialog with pre-defined server parameters (Addresses for regular DNS and sdns-stamp for encrypted(DNSCrypt/DoH) servers)

@AlikhanAliev
Copy link

Behavior of "Choose DNS server from the list" button is incorrect

@zzebrum zzebrum closed this as completed Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants