Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #3012 (After adding a custom user filter rule from the Filtering Log (by clicking on the "Block" button), the button should immediately change from 'Block' to 'Unblock') #3485

Closed
dnovitskyi opened this issue Jul 11, 2020 · 2 comments

Comments

@dnovitskyi
Copy link

Problem Description

The latest nightly build has changed the behavior of filtering log UI after adding a custom user filter rule from the Filtering Log. Issue in question: #3012

We've received feedback from one of our customers (Helpdesk ID: 2576359):

Your decision to force the Block button to change to Unblock after creating a user filter entry from the Filtering Log is not a good idea. Here's why: when I choose to block a DNS server I may also choose to make a second entry based on the CNAME. Forcing me to exit and come back is inconvenient. Furthermore, when I choose to make an entry to the non-DNS user filter, many times I choose to make multiple customized entries. Example: for http://example.com/track/beacons/transparentpixel1x1.gif I would make the following user filter entries: ||example.com/track^ & /beacons/ & transparent*.gif & ||*pixel1x1. If I have to exit each time to do this it becomes more burdensome than before -- especially considering the fact that switching Block to Unblock immediately adds very little - if any - value to AdGuard. This "improvement" is actually not an improvement at all, but rather a waste of time for both the dvelopers and users. Please change it back. Thank you.

Proposed Solution

Either completely revert the change or make Filtering Log switch the "Unblock" button back to "Block" once a user moves from one entry to another.

@artemiv4nov
Copy link
Contributor

We already added behavior to change the 'block' button to 'unblock'. Please, see in the latest nightly

@artemiv4nov artemiv4nov added this to the 3.5 milestone Jul 13, 2020
@dnovitskyi
Copy link
Author

@artemiv4nov The user does not like this change, that's why I've created the issue. A copy of his thoughts is available in the first message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants