Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When importing DNS user rules containing empty lines, these lines are added #4888

Closed
3 of 4 tasks
ESurina opened this issue Jul 31, 2023 · 1 comment
Closed
3 of 4 tasks

Comments

@ESurina
Copy link

ESurina commented Jul 31, 2023

Please answer the following questions for yourself before submitting an issue.

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

AdGuard version

4.0, 4.1

Environment

- OS:11, 12
- Device: Pixel, Xiaomi
- Firmware:

Root access

  • Yes, I have it.

What filters do you have enabled?

No filters

What Stealth Mode options do you have enabled?

No response

Issue Details

Steps to reproduce:

  1. Protection ->DNS protection ->DNS filters ->User rules
  2. Create a file containing some empty strings
  3. Import this file to the user rules (3 dots -> Import)

Expected Behavior

Empty strings are not imported

Actual Behavior

Empty strings are added to the rules.

Screenshots

Screenshot 1:

image

Additional Information

No response

@superlex
Copy link

superlex commented Oct 3, 2023

Hi guys,
just 2 suggestions:

  • this bug regards Ads Blocker - User Rules too;
  • commented lines should be added as well, but without being selected.

Example:
dd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants