Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some apps repeat ad requests every second #511

Closed
ameshkov opened this issue May 1, 2016 · 29 comments
Closed

Some apps repeat ad requests every second #511

ameshkov opened this issue May 1, 2016 · 29 comments
Assignees

Comments

@ameshkov
Copy link
Member

ameshkov commented May 1, 2016

List of apps:
Play Music
Manga Rock

https://www.reddit.com/r/Android/comments/4guine/adguard_25_update_is_live_with_https_filtering/d2mg2t4

The same issue with Play Music.

@ameshkov ameshkov changed the title Magna rock app goes mad because of ad blocking Magna Rock app goes mad because of ad blocking May 4, 2016
@ameshkov ameshkov added this to the 2.6 milestone May 4, 2016
@gshumihin
Copy link

Here's https log of a problem with play music:
adguardlog.txt

@ameshkov
Copy link
Member Author

ameshkov commented May 4, 2016

@gshumihin don't forget about magna rock

@gshumihin gshumihin changed the title Magna Rock app goes mad because of ad blocking Manga Rock app goes mad because of ad blocking May 5, 2016
@gshumihin
Copy link

Here's http request log: https://www.dropbox.com/s/s1pjhsvvzfijl7o/adguard.log
Application name: com.notabasement.mangarock.android.titan
Seems like app loads ads while being in background.

@ameshkov
Copy link
Member Author

@ameshkov
Copy link
Member Author

Instead of an empty response, we should return an error response (500 Internal Server Error for instance). I hope in this case they'll use their exponential backoff strategy:
https://developers.google.com/api-client-library/java/google-http-java-client/backoff#examples

@ameshkov ameshkov assigned ameshkov and unassigned gshumihin May 11, 2016
@ameshkov ameshkov changed the title Manga Rock app goes mad because of ad blocking Some apps repeat ad requests every second May 15, 2016
@ameshkov
Copy link
Member Author

It seems that for GoogleTagManager we should simply return 200 OK response otherwise it may sometimes react with constant request repeating.

@ameshkov
Copy link
Member Author

We should also add two domains to SSL blacklist:
doubleclick.net
googleadservices.com

@TPS
Copy link
Contributor

TPS commented May 17, 2016

We should also add two domains to SSL blacklist:
doubleclick.net
googleadservices.com

If #552 is already accomplished, why's this necessary?

@ameshkov
Copy link
Member Author

If #552 is already accomplished, why's this necessary?

GoogleTagManager may (sometimes) go crazy when we simply drop connections to these domains. And without https filtering this is what we do for these domains.

ameshkov added a commit to AdguardTeam/AdguardFilters that referenced this issue Sep 2, 2016
@Eugene-Savenko
Copy link
Member

The app 'Next', lock screen one, by Microsoft, is being reported in Adguard as a huge ads traffic. Something like hundreds of thousands of requests (daily) to ads. The bandwidth 'saved' reach in about 1gb or so (daily as well).

The NEXON game 'Oz: Broken Kingdom' has the same issue.

Logs and stuff: 1441845

@Eugene-Savenko Eugene-Savenko reopened this Nov 2, 2016
@ameshkov ameshkov removed this from the 2.6 milestone Nov 3, 2016
@ameshkov
Copy link
Member Author

ameshkov commented Nov 3, 2016

@gshumihin please take a look at it.

@ameshkov
Copy link
Member Author

ameshkov commented Nov 3, 2016

@evgeniy-ADG please ask user to record HTTP requests log, it's hard to reproduce this issue with MS apps on our side.

@gshumihin gshumihin removed their assignment Nov 18, 2016
@carlylemiii
Copy link

Goodreads is another such app that goes absolutely nuts:

screenshot_20170902-223402
screenshot_20170902-223411

https://www.dropbox.com/s/p6zquasjmud8kp4/adguard_logs_0209_2233.zip?dl=1

@TPS
Copy link
Contributor

TPS commented Sep 3, 2017

I find, since I use DNS-level blocking, I don't see much of this. Is there a way to enable DNS-blocking per-app, for those who don't want it globally?

@ameshkov
Copy link
Member Author

ameshkov commented Sep 5, 2017

@TPS unfortunately, dns-blocking is always system-wide

@TPS
Copy link
Contributor

TPS commented Sep 13, 2017

Duplicates #786, also?

I'm suddenly having this issue w/ ||csi.gstatic.com^ from the Mobile Ads subscription whenever I open GDrive: it & many related apps go nuts trying to find that server. I even tried the ||csi.gstatic.com^$important & (mentioned elseplace) ||csi.gstatic.com^$empty,important versions. This filter doesn't seem to block @ DNS-level, though it seems like an obvious candidate. Logs attached:

adguard_logs_1309_0518.zip

@ameshkov
Copy link
Member Author

Is can see it in your log file, but I cannot reproduce it

@ameshkov
Copy link
Member Author

Does it still happen?

@TPS
Copy link
Contributor

TPS commented Sep 17, 2017

Yep, everytime I open GDrive: adguard_logs_1709_1921.zip

@TPS
Copy link
Contributor

TPS commented Sep 17, 2017

Heh, ||csi.gstatic.com$important (minus the ^) fixes it! It's properly blocked via DNS. Maybe ^ precludes DNS processing, for some bug/parsing reason?

adguard_logs_1709_1931.zip

@ameshkov
Copy link
Member Author

Hm, ||csi.gstatic.com^ should block it just okay

@ameshkov
Copy link
Member Author

Huh, you're right:)

DNS question contains csi.gstatic.com. with a trailing dot. This is why it does not work properly.

@ameshkov
Copy link
Member Author

Filed a bug report:
#1453

@TPS
Copy link
Contributor

TPS commented Sep 18, 2017

If it's just the trailing . problem, why does ||csi.gstatic.com^ have it & ||csi.gstatic.com not?

@TPS
Copy link
Contributor

TPS commented Sep 18, 2017

||fls-na.amazon.com^ from Spyware subscription has same problem. ||fls-na.amazon.com$important fixes it.

@TPS
Copy link
Contributor

TPS commented Sep 27, 2017

@ameshkov I'm still having this problem, though I thought #1453/AdguardTeam/AdGuardDNS#185 was meant to fix it?!

adguard_logs_2.10.104_2609_2323.zip

@ameshkov
Copy link
Member Author

It appears that these domains shouldn't be blocked on the DNS level as it may break some websites:
https://github.com/AdguardTeam/AdguardDNS/blob/5a6bdbc9ecb7187f63090e05b3fbdb6656e0c25b/Filters/exclusions.txt#L22

However, when you add them to the user filter, they are blocked as user filter is used for DNS filtering.

@TPS
Copy link
Contributor

TPS commented Oct 16, 2017

Ah, ok. Now I understand the context of most of the above. Carry on.

Why is this issue still open, though?

@ameshkov
Copy link
Member Author

Just in case we encounter new issues like that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants