Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some custom filter properties don’t update properly #5171

Closed
3 of 4 tasks
DimitrisKalaboukas opened this issue Jan 15, 2024 · 3 comments
Closed
3 of 4 tasks

Some custom filter properties don’t update properly #5171

DimitrisKalaboukas opened this issue Jan 15, 2024 · 3 comments

Comments

@DimitrisKalaboukas
Copy link

DimitrisKalaboukas commented Jan 15, 2024

Please answer the following questions for yourself before submitting an issue.

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

AdGuard version

4.3.1

Environment

- OS: Android 14
- Device: Samsung Galaxy A54
- Firmware: One UI 6.0

Root access

  • Yes, I have it.

What filters do you have enabled?

AdGuard Base filter, AdGuard Mobile Ads filter, AdGuard Tracking Protection filter, AdGuard URL Tracking filter, AdGuard Social Media filter, AdGuard Annoyances filter, AdGuard DNS filter, EasyList, EasyPrivacy, Greek AdBlock Filter, Fanboy's Annoyances, Peter Lowe's Blocklist, Online Malicious URL Blocklist, Fanboy's Anti-Facebook List, I don't care about cookies, NoCoin Filter List, Dandelion Sprout's Annoyances List, Others

What Stealth Mode options do you have enabled?

Hide your search queries, Send Do-Not-Track signals, Self-destruction of third-party cookies, Disable cache for third-party requests, Block the third-party Authorization header

Issue Details

Steps to reproduce:

  1. Add a test list in custom filters with “! Title: [...]”, “! Description: [...]” and “! Version: [...]” lines
  2. Change title and description and remove “! Version: [...]” line
  3. Update filters

Expected Behavior

Title and description has been updated, while version info has been removed.

Actual Behavior

Title, description and version remains the same as it was when first adding the filter list.

Screenshots

Screenshot 1:

Additional Information

added by @Versty

The description is not displayed for a newly added filter, but will be displayed when that filter is updated.

@Versty
Copy link
Contributor

Versty commented Jan 15, 2024

@DimitrisKalaboukas The title should not be updated because you enter it when adding the filter.
But the description and version should be updated as you expecting. Clearly a bug, reproduces on our side as well.

@DimitrisKalaboukas
Copy link
Author

@Versty Regarding the title, I agree in case it is entered or modified by the user. But, if it is auto-populated based on the filter list's "! Title: [...]" line, it should also be updated if modified by the list developer.

@DimitrisKalaboukas
Copy link
Author

@Versty @maxikuzmin Auto-removal of removed filter list version info hasn’t been fixed. For example, in uBlock Origin lists an invalid “! Version: %version%” line is periodically being added for a short time (probably due to a bug) and then removed completely from the list, but not from AdGuard’s Custom filters info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants