Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters update fails #5321

Closed
5 of 6 tasks
innit86 opened this issue May 15, 2024 · 4 comments
Closed
5 of 6 tasks

Filters update fails #5321

innit86 opened this issue May 15, 2024 · 4 comments

Comments

@innit86
Copy link

innit86 commented May 15, 2024

Please answer the following questions for yourself before submitting an issue

  • Filters were updated before reproducing an issue
  • I checked the knowledge base and found no answer
  • I checked to make sure that this issue has not already been filed

AdGuard version

4.4 Nightly 46

Environment

  • OS version: Android 14
  • Device: Pixel 7 Pro

HTTPS filtering

  • yes, I do

Root access

  • yes, I have it

Integration with AdGuard VPN

  • yes, I do

Routing mode

Automatic proxy

Ad Blocking

No response

Privacy

No response

Social

No response

Annoyances

No response

Security

No response

Language-specific

No response

Other

No response

Which DNS server do you use?

Custom DNS

DNS protocol

DNS-over-HTTPS

Custom DNS

No response

What Stealth Mode options do you have enabled?

No response

Issue Details

Steps to reproduce:

  1. Tap update filters.
  2. Some filters don't update.

Expected Behavior

Filters should update.

Actual Behavior

Some filters fail to update.

Screenshots

Screenshot_20240515-172302~2.png

Additional Information

Show on update page which filters and userscripts fail to update so that they could be disabled or removed.

@innit86 innit86 added the Bug label May 15, 2024
@innit86 innit86 changed the title Filter update fails Filters update fails May 15, 2024
@adguard-bot adguard-bot assigned tengizmax and unassigned Versty May 17, 2024
@tengizmax
Copy link

Thank you for reporting this issue.

We're looking forward to tell you some about UX accessibility of our app. To see additional info about failed updates you can tap on it (you marked it by red arrow on your screenshot).

To help us understand the problem better, could you please answer a few questions?

  1. Can you please specify which filter is not updating?
  2. Have you tried switching to a different Wi-Fi network or using mobile data and update filters again ?

Your answers will help us investigate this issue further.

@innit86
Copy link
Author

innit86 commented May 18, 2024

Thank you for reporting this issue.

We're looking forward to tell you some about UX accessibility of our app. To see additional info about failed updates you can tap on it (you marked it by red arrow on your screenshot).

To help us understand the problem better, could you please answer a few questions?

  1. Can you please specify which filter is not updating?
  2. Have you tried switching to a different Wi-Fi network or using mobile data and update filters again ?

Your answers will help us investigate this issue further.

I don't know which filters are not updating because tapping on "content blocker filters", "dns filters" & "userscripts" does not reveal it.

This is why I asked you to implement a feature that will allow user to see clearly which filters don't work and fail to update.

For example:

  1. Tap update filters.
  2. Some filters update and some don't.
  3. Tap on the category in which some filters failed to update.
  4. User is presented with a list of all filters that properly updated and those that didn't update.
  5. User now know the culprit and can disable or remove the non-working filters or userscripts.

@Gestrid
Copy link

Gestrid commented May 21, 2024

This "bug" seems to have made it into the stable release as well.

I was experiencing the same "userscripts failed to update" error, so I went into my userscripts settings and disabled them one at a time. I found the cause of my specific error. One of the userscripts I'd installed now leads to a 404 page. For some reason, prior to updating to v4.4, this did not throw an error. Now, it does.

The 404 is not caused by AdGuard. The user who created the userscript was apparently blocked on GitLab, and their content was removed from the site.

I can't confirm this for myself since all my filters (including my custom ones) are working properly, but perhaps one of OP's filters now leads to a 404 page when trying to update?

@tengizmax
Copy link

Duplicate of #5220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants