New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start using new filters server instead of AG backend #863

Closed
ameshkov opened this Issue Oct 24, 2016 · 10 comments

Comments

Projects
None yet
4 participants
@ameshkov
Member

ameshkov commented Oct 24, 2016

Metadata

https://filters.adtidy.org/[platform]/filters.json

Translations

https://filters.adtidy.org/[platform]/filters_i18n.json

Filters

https://filters.adtidy.org/[platform]/filters/[filterId].txt

For instance:
https://filters.adtidy.org/[platform]/filters/2.txt
https://filters.adtidy.org/[platform]/filters/[filterId]_optimized.txt

_optimized suffix stands for "mobile optimized" filters versions.
We use it by default in case of iOS and Android apps.

[platform] possible values:

  • windows - Adguard for Windows
  • mac - Adguard for Mac
  • android - Adguard for Android
  • ios - Adguard for iOS
  • extension/chromium - Chromium browser extension
  • extension/firefox - Firefox extension
  • extension/safari - Safari extension

I suppose we could ignore Checksum: field for now as anyway we use https.

@ameshkov ameshkov added this to the 2.8 milestone Oct 24, 2016

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Oct 25, 2016

Contributor

@gorhill, this is likely relevant to uBlock origin, as several builtin filterlists are from AdGuard.

Contributor

TPS commented Oct 25, 2016

@gorhill, this is likely relevant to uBlock origin, as several builtin filterlists are from AdGuard.

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Oct 27, 2016

Member

Yep, indeed.

@gorhill it would be better if you switch to this server instead of using adguard.com.

Russian filter:
https://filters.adtidy.org/extension/chromium/filters/1.txt

English filter:
https://filters.adtidy.org/extension/chromium/filters/2.txt

Turkish filter:
https://filters.adtidy.org/extension/chromium/filters/13.txt

Filters updates requests create a huge load, so moving filters to a CDN will help us with unloading the website.

Member

ameshkov commented Oct 27, 2016

Yep, indeed.

@gorhill it would be better if you switch to this server instead of using adguard.com.

Russian filter:
https://filters.adtidy.org/extension/chromium/filters/1.txt

English filter:
https://filters.adtidy.org/extension/chromium/filters/2.txt

Turkish filter:
https://filters.adtidy.org/extension/chromium/filters/13.txt

Filters updates requests create a huge load, so moving filters to a CDN will help us with unloading the website.

@gorhill

This comment has been minimized.

Show comment
Hide comment
@gorhill

gorhill Oct 27, 2016

Ok I will change -- but can't just now, because of early design choice years ago -- the key for a list is the URL itself, so there currently no way for me to change the URL without losing a user's selection of the list. Do you plan to redirect the old URLs to the new ones server-side?

gorhill commented Oct 27, 2016

Ok I will change -- but can't just now, because of early design choice years ago -- the key for a list is the URL itself, so there currently no way for me to change the URL without losing a user's selection of the list. Do you plan to redirect the old URLs to the new ones server-side?

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Oct 27, 2016

Member

Do you plan to redirect the old URLs to the new ones server-side?

Oh, didn't think about it until you've mentioned it:)

Yep, we will definitely do it.

Member

ameshkov commented Oct 27, 2016

Do you plan to redirect the old URLs to the new ones server-side?

Oh, didn't think about it until you've mentioned it:)

Yep, we will definitely do it.

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Oct 27, 2016

Member

the key for a list is the URL itself

What are you planning to do with EasyList? They've also changed URLs recently.

Member

ameshkov commented Oct 27, 2016

the key for a list is the URL itself

What are you planning to do with EasyList? They've also changed URLs recently.

@gorhill

This comment has been minimized.

Show comment
Hide comment
@gorhill

gorhill Oct 27, 2016

I plan/started to fix this, to no longer use the URL as a key.

gorhill commented Oct 27, 2016

I plan/started to fix this, to no longer use the URL as a key.

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Oct 27, 2016

Contributor

[platform] possible values:

  • extension/firefox - Firefox Safari extension

@ameshkov That can't be correct, right? 😜

@gorhill Based on the above, the current Ff version of uBo would need the extension/firefox URLs, I think, though after gorhill/uBlock#622 (@ameshkov, I think this discussion is relevant to AG Ff, also) becomes required by a stable Ff version, I think then you'd switch over to extension/chromium URLs, though I hope you'd keep up current uBo for those of us on legacy platforms (e.g., Pale Moon). 🙏

Contributor

TPS commented Oct 27, 2016

[platform] possible values:

  • extension/firefox - Firefox Safari extension

@ameshkov That can't be correct, right? 😜

@gorhill Based on the above, the current Ff version of uBo would need the extension/firefox URLs, I think, though after gorhill/uBlock#622 (@ameshkov, I think this discussion is relevant to AG Ff, also) becomes required by a stable Ff version, I think then you'd switch over to extension/chromium URLs, though I hope you'd keep up current uBo for those of us on legacy platforms (e.g., Pale Moon). 🙏

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Oct 28, 2016

Member

@ameshkov That can't be correct, right? 😜

Just a typo, thanks for noticing it:)

In fact there's no difference between extension/firefox and extension/chromium, we've divided it just in case:)

Member

ameshkov commented Oct 28, 2016

@ameshkov That can't be correct, right? 😜

Just a typo, thanks for noticing it:)

In fact there's no difference between extension/firefox and extension/chromium, we've divided it just in case:)

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Oct 28, 2016

Member

@ameshkov, I think this discussion is relevant to AG Ff, also

Just recently tested it. I think we'll wait a bit more until WebExtensions API becomes more reliable.

Member

ameshkov commented Oct 28, 2016

@ameshkov, I think this discussion is relevant to AG Ff, also

Just recently tested it. I think we'll wait a bit more until WebExtensions API becomes more reliable.

@Revertron

This comment has been minimized.

Show comment
Hide comment
@Revertron

Revertron Oct 31, 2016

Member

Done.

Member

Revertron commented Oct 31, 2016

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment