New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid HTML issues #1222

Closed
Alex-302 opened this Issue Aug 9, 2016 · 19 comments

Comments

Projects
None yet
5 participants
@Alex-302
Member

Alex-302 commented Aug 9, 2016

EDIT We will keep this issue open. Please add comments here for new issues.

drive.ru
http://www.bosscast.net/tsn.php (https://forum.adguard.com/index.php?threads/http-www-bosscast-net.11861/)

@Alex-302 Alex-302 added the bug label Aug 9, 2016

@ameshkov ameshkov added this to the 6.1 R2 milestone Aug 9, 2016

@ameshkov ameshkov changed the title from drive.ru - Adguard is not injected to HTML to Invalid HTML issues Aug 15, 2016

@Alex-302

This comment has been minimized.

Show comment
Hide comment

@ameshkov ameshkov assigned suhan3z and unassigned ameshkov Sep 5, 2016

@ameshkov ameshkov assigned adbuker and unassigned suhan3z Sep 29, 2016

@adbuker adbuker closed this Oct 11, 2016

@Alex-302

This comment has been minimized.

Show comment
Hide comment
@Alex-302

This comment has been minimized.

Show comment
Hide comment
@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Oct 17, 2016

Member

@adbuker could you please check if HTML is detected ok for those new links?

Member

ameshkov commented Oct 17, 2016

@adbuker could you please check if HTML is detected ok for those new links?

@adbuker

This comment has been minimized.

Show comment
Hide comment
@adbuker

adbuker Oct 17, 2016

@ameshkov ok, I've got it

adbuker commented Oct 17, 2016

@ameshkov ok, I've got it

@adbuker adbuker reopened this Oct 17, 2016

@Alex-302

This comment has been minimized.

Show comment
Hide comment
@Alex-302
Member

Alex-302 commented Oct 18, 2016

@adbuker

This comment has been minimized.

Show comment
Hide comment
@adbuker

adbuker Oct 19, 2016

@Alex-302 now it's ok with http://news.xinhuanet.com/english/2016-10/18/c_135763685.htm (http://c2n.me/3Ds2aHC). Probably this has been auto-fixed when were resolved previous errors

adbuker commented Oct 19, 2016

@Alex-302 now it's ok with http://news.xinhuanet.com/english/2016-10/18/c_135763685.htm (http://c2n.me/3Ds2aHC). Probably this has been auto-fixed when were resolved previous errors

@Alex-302

This comment has been minimized.

Show comment
Hide comment
@Alex-302

Alex-302 Oct 19, 2016

Member

@adbuker sorry, my mistake. Injecting works, but my rule is not injected(from social filter)
xinhuanet.com##td[align="right"] > a[href^="javascript:(function(){window.open("]

Member

Alex-302 commented Oct 19, 2016

@adbuker sorry, my mistake. Injecting works, but my rule is not injected(from social filter)
xinhuanet.com##td[align="right"] > a[href^="javascript:(function(){window.open("]

@adbuker

This comment has been minimized.

Show comment
Hide comment
@adbuker

adbuker Oct 19, 2016

ok, good:)

adbuker commented Oct 19, 2016

ok, good:)

@ameshkov ameshkov removed this from the 6.1 R2 milestone Oct 20, 2016

@adbuker

This comment has been minimized.

Show comment
Hide comment
@adbuker

adbuker Oct 25, 2016

Adguard injects its contents to a js file so the page is broken: http://www.nocutnews.co.kr/news/4673964
Problematic url: http://www.nocutnews.co.kr/js/nocutnews.v2.htm
The response body starts with //<script type=.... </script>
and Adguard injects its contents between // and <script>, so the <script> is no longer "commented" and the whole script is broken

"1222 - 2"

adbuker commented Oct 25, 2016

Adguard injects its contents to a js file so the page is broken: http://www.nocutnews.co.kr/news/4673964
Problematic url: http://www.nocutnews.co.kr/js/nocutnews.v2.htm
The response body starts with //<script type=.... </script>
and Adguard injects its contents between // and <script>, so the <script> is no longer "commented" and the whole script is broken

"1222 - 2"

@Alex-302

This comment has been minimized.

Show comment
Hide comment
@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Nov 17, 2016

Member

Simply add base href= to known tags.

Member

ameshkov commented Nov 17, 2016

Simply add base href= to known tags.

@adbuker

This comment has been minimized.

Show comment
Hide comment
@adbuker

adbuker Jan 18, 2017

resolve in ADWIN-CR-108

adbuker commented Jan 18, 2017

resolve in ADWIN-CR-108

@Alex-302

This comment has been minimized.

Show comment
Hide comment
@adbuker

This comment has been minimized.

Show comment
Hide comment
@adbuker

adbuker Feb 8, 2017

@Alex-302 ok, I've got it

adbuker commented Feb 8, 2017

@Alex-302 ok, I've got it

@adbuker

This comment has been minimized.

Show comment
Hide comment
@adbuker

adbuker Mar 2, 2017

ADWIN-CR-146

adbuker commented Mar 2, 2017

ADWIN-CR-146

@AdamWr

This comment has been minimized.

Show comment
Hide comment
@AdamWr

AdamWr Oct 6, 2017

I think this website has also invalid HTML and AdGuard is not injected.
http://filmjethdizle.club/

AdamWr commented Oct 6, 2017

I think this website has also invalid HTML and AdGuard is not injected.
http://filmjethdizle.club/

@adbuker

This comment has been minimized.

Show comment
Hide comment
@adbuker

adbuker Oct 6, 2017

Yes, it is an invalid HTML. In particular, this HTML-page starts with closing </a> meta tag.

adbuker commented Oct 6, 2017

Yes, it is an invalid HTML. In particular, this HTML-page starts with closing </a> meta tag.

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Nov 30, 2017

Member

Moved to CoreLibs:
AdguardTeam/CoreLibs#136

Member

ameshkov commented Nov 30, 2017

Moved to CoreLibs:
AdguardTeam/CoreLibs#136

@ameshkov ameshkov closed this Nov 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment