Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid HTML issues #1222

Closed
Alex-302 opened this issue Aug 9, 2016 · 19 comments
Closed

Invalid HTML issues #1222

Alex-302 opened this issue Aug 9, 2016 · 19 comments
Assignees
@adbuker
Labels
bug

Comments

@Alex-302
Copy link
Member

Alex-302 commented Aug 9, 2016 •
edited by ameshkov
Loading

EDIT We will keep this issue open. Please add comments here for new issues.

drive.ru
http://www.bosscast.net/tsn.php (https://forum.adguard.com/index.php?threads/http-www-bosscast-net.11861/)
@Alex-302 Alex-302 added the bug label Aug 9, 2016
@Alex-302 Alex-302 mentioned this issue Aug 9, 2016
Closed
@ameshkov ameshkov added this to the 6.1 R2 milestone Aug 9, 2016
@ameshkov ameshkov changed the title drive.ru - Adguard is not injected to HTML Invalid HTML issues Aug 15, 2016
@Alex-302
Copy link
Member Author

[NSFW] http://imgchilibum.ru/v.php?id=ec14be70d7a754a81f4d54a59c71209b

@ameshkov ameshkov assigned suhan3z and unassigned ameshkov Sep 5, 2016
@ameshkov ameshkov assigned adbuker and unassigned suhan3z Sep 29, 2016
@adbuker adbuker closed this as completed Oct 11, 2016
@Alex-302
Copy link
Member Author

@adbuker Another one NSFW
http://www.porno34.net/liseli-porno/ah-su-liseli-surtukler-ne-harika.html

@Alex-302
Copy link
Member Author

The same
http://www.aksam.com.tr/video/guncel/kadir-topbastan-tatlici-aliye-telefon/24438

@ameshkov
Copy link
Member

@adbuker could you please check if HTML is detected ok for those new links?

@adbuker
Copy link

adbuker commented Oct 17, 2016

@ameshkov ok, I've got it

@adbuker adbuker reopened this Oct 17, 2016
@Alex-302
Copy link
Member Author

Alex-302 commented Oct 18, 2016 •
edited
Loading

No Adguard injections
http://news.xinhuanet.com/english/2016-10/18/c_135763685.htm

@adbuker
Copy link

adbuker commented Oct 19, 2016

@Alex-302 now it's ok with http://news.xinhuanet.com/english/2016-10/18/c_135763685.htm (http://c2n.me/3Ds2aHC). Probably this has been auto-fixed when were resolved previous errors

@Alex-302
Copy link
Member Author

@adbuker sorry, my mistake. Injecting works, but my rule is not injected(from social filter)
xinhuanet.com##td[align="right"] > a[href^="javascript:(function(){window.open("]

@adbuker
Copy link

adbuker commented Oct 19, 2016

ok, good:)

@ameshkov ameshkov removed this from the 6.1 R2 milestone Oct 20, 2016
@adbuker
Copy link

adbuker commented Oct 25, 2016 •
edited
Loading

Adguard injects its contents to a js file so the page is broken: http://www.nocutnews.co.kr/news/4673964
Problematic url: http://www.nocutnews.co.kr/js/nocutnews.v2.htm
The response body starts with //<script type=.... </script>
and Adguard injects its contents between // and <script>, so the <script> is no longer "commented" and the whole script is broken

"1222 - 2"

@Alex-302
Copy link
Member Author

@adbuker
Another one:
http://73online.ru/
http://ipic.su/img/img7/fs/kiss_84kb.1479402900.png

@Alex-302 Alex-302 mentioned this issue Nov 17, 2016
Closed
@ameshkov
Copy link
Member

Simply add base href= to known tags.

@adbuker
Copy link

adbuker commented Jan 18, 2017

resolve in ADWIN-CR-108

@Alex-302
Copy link
Member Author

Alex-302 commented Feb 8, 2017

@adbuker
please check this page:
http://www.world-art.ru/cinema/cinema_trailers.php?id=8475&trailer_id=9007
AG is not injected.
Page code:
https://gist.github.com/Alex-302/38f330d224f6abeb4e7ad50bff6e174c

@Alex-302 Alex-302 mentioned this issue Feb 8, 2017
Closed
@adbuker
Copy link

adbuker commented Feb 8, 2017

@Alex-302 ok, I've got it

@adbuker
Copy link

adbuker commented Mar 2, 2017

ADWIN-CR-146

@AdamWr
Copy link
Member

AdamWr commented Oct 6, 2017

I think this website has also invalid HTML and AdGuard is not injected.
http://filmjethdizle.club/

@adbuker
Copy link

adbuker commented Oct 6, 2017

Yes, it is an invalid HTML. In particular, this HTML-page starts with closing </a> meta tag.

@ameshkov ameshkov mentioned this issue Nov 30, 2017
Closed
@ameshkov
Copy link
Member

Moved to CoreLibs:
AdguardTeam/CoreLibs#136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adbuker adbuker

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@suhan3z @ameshkov @Alex-302 @adbuker @AdamWr