Cannot export settings in nightly build

[pzhg]

Steps to reproduce

1. Running the recent nightly build of Adguard windows (v 6.3.1036.3347)
2. Settings -- Export settings
3. Error: "Error while exporting settings. The operation was interrupted."

Expected behavior

Export to a .adg file

Actual behavior

Failed to export

Screenshot:

Customer ID

Your environment

• Environment name and version (e.g. Chrome 59):
  Firefox 52 ESR
  Edge (with Windows 10 1803)
• Operating system and version (e.g. Windows 10, v.1703, build 15063.413)
  Windows 10 1803 17134.8

[BlazDT]

What is the save location?

[ameshkov]

@pzhg could you please send us the log files to devteam at adguard.com

[pzhg]

@BlazDT I have tried various saving locations, including D:, my documents directory and my download folder.

@ameshkov I have sent the logs folder inside C:\ProgramData\Adguard to you. Here is a snapshot from the logfile:

ERROR, Adguard, 7, 14.05.30 7:31:50.045, ClientSettingsService.ExportSettings: Error - System.ServiceModel.FaultException`1[[System.ServiceModel.ExceptionDetail, System.ServiceModel, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]]: Illegal characters in path.
Source: mscorlib
Stack trace: 
Server stack trace: 
   at System.ServiceModel.Channels.ServiceChannel.ThrowIfFaultUnderstood(Message reply, MessageFault fault, String action, MessageVersion version, FaultConverter faultConverter)
   at System.ServiceModel.Channels.ServiceChannel.HandleReply(ProxyOperationRuntime operation, ProxyRpc& rpc)
   at System.ServiceModel.Channels.ServiceChannel.Call(String action, Boolean oneway, ProxyOperationRuntime operation, Object[] ins, Object[] outs, TimeSpan timeout)
   at System.ServiceModel.Channels.ServiceChannelProxy.InvokeService(IMethodCallMessage methodCall, ProxyOperationRuntime operation)
   at System.ServiceModel.Channels.ServiceChannelProxy.Invoke(IMessage message)

Exception rethrown at [0]: 
   at System.Runtime.Remoting.Proxies.RealProxy.HandleReturnMessage(IMessage reqMsg, IMessage retMsg)
   at System.Runtime.Remoting.Proxies.RealProxy.PrivateInvoke(MessageData& msgData, Int32 type)
   at Adguard.Ipc.Contract.IApplicationApiFacade.ExportSettings(String exportPath)
   at Adguard.Ipc.Client.ApplicationApiClient.<>c__DisplayClass65.<ExportSettings>b__64(IApplicationApi api)
   at Adguard.Ipc.Client.ApplicationApiClient.ExecuteServiceMethod(UseServiceDelegate codeBlock)
   at Adguard.Ipc.Client.ApplicationApiClient.CallServiceMethod(UseServiceDelegate codeBlock)
   at Adguard.Ipc.Client.ApplicationApiClient.ExportSettings(String exportPath)
   at Adguard.UI.Service.Impl.ClientSettingsService.pJDjRLUbdHeltpgRQKD(Object , Object )
   at Adguard.UI.Service.Impl.ClientSettingsService.ExportSettings(String exportPath)

[pzhg]

I also tested on another computer and the bug is still there. I recorded a GIF animation of reproducing this bug.

I guess that it might be caused by the handling of directory path stings in some recent builds.

[pzhg]

I have tested a simplest path string: "D:\test.adg". Still no luck.

Just for information of you guys.

Thanks!

[adbuker]

@pzhg , thanks for the info. We'll work on it

[pzhg]

@The-Commissioner I use the Japanese calendar so the date should be "Heisei 30-5-14", where Heisei is the era name and Heisei 30 year is 2018.

The settings exporting function works well before I switched to the nightly channel. There must be something changed in recent builds.

I also test "D:\test.adg", also does not work.

[pzhg]

@The-Commissioner Some particular filters are only available for ublock. Anyway I use adguard as my main ad blocker and loves it.

[adbuker]

resolved in adguard-windows/pull-requests/99