Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextNow - missed ads #177

Closed
ameshkov opened this issue Oct 11, 2016 · 32 comments
Closed

TextNow - missed ads #177

ameshkov opened this issue Oct 11, 2016 · 32 comments
Assignees
@Alex-302 @gshumihin

Comments

@ameshkov
Copy link
Member

ameshkov commented Oct 11, 2016 •
edited

Link to the app:
https://itunes.apple.com/us/app/textnow-free-text-+-calls/id314716233?mt=8

Source:
http://forums.macrumors.com/threads/ios-9-content-blockers-mini-reviews.1918483/page-36#post-23693900
@ameshkov ameshkov added the PRO label Oct 11, 2016
@gshumihin gshumihin mentioned this issue Oct 12, 2016
Closed
@gshumihin
Copy link

gshumihin commented Oct 12, 2016 •
edited

There is no ads inTextNow for me.

@jo2dan23
Copy link

admarvel.s3.amazonaws.com
www.leanplum.com

@ganja24
Copy link

ganja24 commented Oct 12, 2016

Which filters do you have enable? I still see the ads on TextNow?

@gshumihin
Copy link

@ganja24 in-apps ads are filtered by DNS, so it doesn't really matters what filters are enabled.

@ganja24
Copy link

ganja24 commented Oct 13, 2016

I provided the screenshots seems like ads won't go away for these 2 apps

@ganja24
Copy link

ganja24 commented Oct 13, 2016

As you can see in the pics Adguard DNS is enabled but the in app ads for both apps TextNow and Fongo are showing. How is it possible you are not seeing ads and I am seeing the ads? Did you purchase in app to remove ads?

@jo2dan23
Copy link

The two hostnames i posted above are probably causing the ads. They are both ad companys

@jo2dan23
Copy link

Leanplum is the most complete mobile marketing platform it says

@ameshkov
Copy link
Member Author

I suppose @jo2dan23 is right, we should block both

@ameshkov
Copy link
Member Author

@Alex-302 ?

@Alex-302
Copy link
Member

@ameshkov
Added to Mobile filter

||admarvel.s3.amazonaws.com^$empty
||leanplum.com^$empty

Alex-302 added a commit to AdguardTeam/AdguardFilters that referenced this issue Oct 17, 2016
@Alex-302
TextNow AdguardTeam/AdguardForiOS#177
5039e56
@Alex-302
Copy link
Member

Please don't close it.
I will check these rules in DNS filter later and close.

@ganja24
Copy link

ganja24 commented Oct 17, 2016

In app ads for TextNow is still showing and thread is closed?

@Alex-302 Alex-302 reopened this Oct 17, 2016
@Alex-302
Copy link
Member

Strange. Please Collect a new log.

@jo2dan23
Copy link

No ads seen on my side and thats with no premium purchased.

@ganja24
Copy link

ganja24 commented Oct 17, 2016

How do I collect a log?

@gshumihin
Copy link

You can send Bug report from app. Log will be included by default.

@ameshkov
Copy link
Member Author

@gshumihin it'd be better if you use fiddler to extract requests done by the app.

@gshumihin
Copy link

gshumihin commented Oct 18, 2016 •
edited

Here's Fiddler log:
TextNow.saz.txt

@ameshkov
Copy link
Member Author

@Alex-302 please take a look.

@gshumihin next time export it in the HTTP archive format so that we could use softwareishard.com/har/viewer/ to analyze.

@Alex-302
Copy link
Member

@gshumihin Please make a screenshot of the banner.
And check this rule

||iadsdk.apple.com^

You can do it with Adguard for windows, when iPhone is connected through Fiddler.

@gshumihin
Copy link

gshumihin commented Oct 19, 2016 •
edited

I have no ads in this app. Read 2nd message here.

@ameshkov
Copy link
Member Author

In fact as i know they also use qwapi.com for iAds.

@gshumihin please check that blocking these two domains won't break the app:
iadsdk.apple.com
qwapi.com

If the app is ok, we should add both domains to "mobile ads filter".

@ganja24
Copy link

ganja24 commented Oct 20, 2016

firehose.us-west-2.amazonaws.com

cognito-identity.us-east-1.amazonaws.com

I noticed these 2 above possible are parts of the in app ads showing in the Adguard Pro DNS requests log. Possible the ads are targeted for different regions is why i see ads and some don't?

@ameshkov
Copy link
Member Author

@ganja24

First one belongs to Amazon Kinesis
Second one belongs to Amazon Cognito.

These are not ad servers, so blocking it could mess with apps work.

JFYI, in the next version you'll be able to block any DNS request manually using your user filter (#161), so you won't need to wait until DNS rules are updated and check anything manually.

@gshumihin
Copy link

Looks like app works fine with this 2 domain added to blacklist. But finally, I was able to see banner in this app:

![TextNow](https://cloud.githubusercontent.com/assets/8577547/19559453/9cabb528-96d8-11e6-8d4a-74bff9aa8a35.jpg)
And here's log: [TextNow.saz.txt](https://github.com/AdguardTeam/AdguardForiOS/files/541649/TextNow.saz.txt)

@ameshkov
Copy link
Member Author

@gshumihin i am pretty sure this ad is built-in.

@Alex-302 could you please check the log? If everything is ok, we should add these two domains to mobile ads filter.

@gshumihin
Copy link

Yeah I think this is built-in too.

@Alex-302
Copy link
Member

@ameshkov I see only iadsdk.apple.com(blocked), but no qwapi.com
@gshumihin do you see only the dummy at the bottom? Top banner should be blocked.

@gshumihin
Copy link

Yes, only dummy at the bottom, nothing else.

@Alex-302
Copy link
Member

Ok, iadsdk.apple.com is in DNS filter now.

@gshumihin
Copy link

I guess we can close this one?

IvanIin added a commit that referenced this issue Jun 22, 2018
@IvanIin
Merge pull request #177 in ADGUARD-IOS/adguard-ios from bug/ui_fixes …
947c33b 
…to master

Squashed commit of the following:

commit 472bd13d78a4db47e8e74a3797eb87bb500e9bc2
Merge: acff989 8b9f184
Author: Ivan Ilin <i.ilin@adguard.com>
Date:   Sat Jun 9 13:25:27 2018 +0300

    Merge commit '8b9f18409939ce15725133cd1b0650846011842e' into bug/ui_fixes

commit acff989f85717373d38fd4ef6d06c4d6ee55964b
Author: Ivan Ilin <i.ilin@adguard.com>
Date:   Sat Jun 9 12:43:41 2018 +0300

    ui fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alex-302 Alex-302

@gshumihin gshumihin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ameshkov @Alex-302 @gshumihin @jo2dan23 @ganja24