Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Banners are not blocked on mobile01.com #46

Closed
ameshkov opened this issue Nov 23, 2015 · 3 comments
Closed

Banners are not blocked on mobile01.com #46

ameshkov opened this issue Nov 23, 2015 · 3 comments
Assignees
@Stillness-2
Labels
Bug
Milestone
1.0.3

Comments

@ameshkov
Copy link
Member

Must be blocked by /mod_ad/* rule.
Works on desktop Safari, but for some reason it does not work on iOS.

Examples:
http://attach2.mobile01.com/image/mod_ad/mobile01-36b57f5bf0bfb3229ecd579a41ad4f83.htm?ad_url=http%3A%2F%2Fwww.mobile01.com%2Fadredir.php%3Fid%3D59043&clickTAG=http%3A%2F%2Fwww.mobile01.com%2Fadredir.php%3Fid%3D59043
http://attach2.mobile01.com/image/mod_ad/mobile01-245219aaeb3d2d85d2d68fee85e7a650.jpg
@ameshkov ameshkov added the Bug label Nov 23, 2015
@ameshkov ameshkov added this to the 1.0.3 milestone Nov 23, 2015
@ameshkov
Copy link
Member Author

We should have added "document" to "resource-type" map. Otherwise iframes are not blocked.

ameshkov added a commit to AdguardTeam/AdguardBrowserExtension that referenced this issue Nov 23, 2015
@ameshkov
https://github.com/AdguardTeam/AdguardForiOS/issues/46
bf24631
@ameshkov
Copy link
Member Author

Fixed it

@ameshkov
Copy link
Member Author

Shhh, the situation is even better on OS X, but nothing has changed on iOS

UPD Testing 80lvl, forgot to turn content blocker on. Everything is good.

IvanIin added a commit that referenced this issue Mar 6, 2018
@IvanIin
Merge pull request #46 in ADGUARD-IOS/adguard-ios from bug/561 to master
ad08e32 
Squashed commit of the following:

commit 31438342ce20758a35fe638472f8a70df83afc60
Author: Ivan Ilin <ivanilin@Ivans-MacBook-Pro.local>
Date:   Wed Jan 10 18:53:32 2018 +0300

    change dnscrypt port
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Stillness-2 Stillness-2

Labels
Bug
Projects
None yet
Milestone
1.0.3
Development

No branches or pull requests
2 participants
@Stillness-2 @ameshkov