Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI][Feature Request] Support scaling for iPhone X (18:9) #513

Closed
Vincent-Michael opened this issue Nov 3, 2017 · 14 comments
Closed

[UI][Feature Request] Support scaling for iPhone X (18:9) #513

Vincent-Michael opened this issue Nov 3, 2017 · 14 comments
Assignees
Labels
Milestone

Comments

@Vincent-Michael
Copy link

2017-11-03 19 52 15

Support for iPhone X (18:9)

@danidoedel
Copy link

Yes... please! So ugly right now... ;)

@mikeoleary7528
Copy link

Couldn’t agree more

@zebrum zebrum added this to the 1.3.3 milestone Nov 7, 2017
@zebrum
Copy link
Member

zebrum commented Nov 7, 2017

should be ok in the next build

@vozersky vozersky added the UI label Nov 7, 2017
@zebrum
Copy link
Member

zebrum commented Nov 10, 2017

@Vincent-Michael @danidoedel @mikeoleary7528 guys! is anyone of you in beta test program? any difference with new beta on iPhone X?

@danidoedel
Copy link

@zebrum Yeah, much better now ;) Thank you!

Not sure if that is iPhone X related (missing active filter rules etc). If you click on „edit“ and go back it will be displayed though:

87f34e70-1acd-4663-8bb0-cf716bd4679b

Also, the splash screen looks a bit weird (black bars at the top and bottom for a second). Can‘t screenshot it but I‘ll try if I can record it later.

@Vincent-Michael
Copy link
Author

Vincent-Michael commented Nov 11, 2017

https://www.dropbox.com/s/y1wwgi90u0yq5f9/2017-11-11%2011.47.20.mp4?dl=0 yep, has bad look @zebrum

@danidoedel
Copy link

@zebrum Another glitch while saving filter rules:

8bd43711-ac25-43e7-9b89-ebab57012166

@IvanIin
Copy link
Contributor

IvanIin commented Nov 15, 2017

fixed

@IvanIin IvanIin closed this as completed Nov 15, 2017
@SebastianRasch
Copy link

@IvanIin I hope you also fixed the problem where you can’t edit the last filters in the user filter page when the list of filters is longer than one page? They would be covered by the keyboard and there’s no way to reach them on the iPhone X.

@zebrum
Copy link
Member

zebrum commented Nov 16, 2017

@Superkloton yeah, that has been fixed.

@SebastianRasch
Copy link

Awesome! 👍🏻

@danidoedel
Copy link

@zebrum New beta is much better on iPhone X. Just one thing I noticed, this text looks a bit too big for the size of the box:

dcc15ffd-e673-4e32-9367-d0657caed4e1

I would suggest to use the same font size used here:

98c16fcb-89da-46f8-9b9f-af472d6b0744

@zebrum
Copy link
Member

zebrum commented Nov 23, 2017

Soon I hope we will get our iphone X!

@IvanIin please pay attention to this screenshots.

@danidoedel
Copy link

@zebrum Another small glitch. Watch the search field jumping down a few pixels:

e4d10650-8f9f-44b0-ad19-966bbab7f335

adguard pushed a commit that referenced this issue Dec 6, 2019
* commit '125de5c48b06ea1093943490b34bd251d47d02d2':
  select button alligned with other elements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants