Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS filtering / privacy module disabled after some time #771

Closed
kevandoyle2 opened this issue May 7, 2018 · 71 comments
Closed

DNS filtering / privacy module disabled after some time #771

kevandoyle2 opened this issue May 7, 2018 · 71 comments
Assignees

Comments

@kevandoyle2
Copy link

kevandoyle2 commented May 7, 2018

This has been occurring in all 3 modes, including the new mode of full-tunnel (with the VPN icon, a feature that I assume is new as of the update yesterday). When I say disabled, I do not mean it toggles itself off, rather, it continues to be toggled on but it will not filter DNS traffic and sometimes stop internet connections all together.

Steps to reproduce

  1. Enable the privacy module
  2. Close the app and continue to use device as normal, opening apps that run ads and using them
  3. After using an app for a few seconds, close it. Open the Adguard app again and open the DNS request log. Close request log and repeat 2 and 3. If nothing happens, try switching between wifi and cellular networks. Another way to induce this issue is by switching between the two full-tunnel modes while the module is enabled.
  4. Eventually, device traffic will stop being filtered, even though the privacy module remains enabled, allowing ads to be displayed.

I have not tried this with split-tunnel, only with the new and old version of full-tunnel. When this bug happens, I have found turning the module off and on again will usually fix it, but in some cases I have had to restart my entire device to get it working again. It should be able to remain connected continuously, even when switching between cellular and wifi networks, and between modes.

Customer ID

1860764

Your environment

  • Device model and storage size: iPhone 8 64gb
  • Operating system and version: iOS 11.3.1
  • Browser: Safari
  • Wi-fi or mobile internet connection: BOTH
@ghost
Copy link

ghost commented May 8, 2018

Same thing happens to me.
After the latest update 2.1.0, with "Full-Tunnel" mode I have no connection to the internet (wifi or mobile).
"Split-Tunnel" works fine.

AdGuard Pro 2.1.0
iPhone 7 on iOS 11.0.3

@IvanIin
Copy link
Contributor

IvanIin commented May 8, 2018

@kevandoyle2 @rafuse
To resolve this issue i need logs from your devices. Please choose "report an issue" -> "contact the support" to send us logs and write your user ids here. Also write a time when such behavior was observed.

@kevandoyle2
Copy link
Author

My user ID as per the auto reply email: 1860764

@IvanIin
Copy link
Contributor

IvanIin commented May 8, 2018

@kevandoyle2
I did not find not blocked advertising domains in the logs. Could you specify the exact time when the advertisement appears?

@kevandoyle2
Copy link
Author

kevandoyle2 commented May 8, 2018

It is no advertisement or time in particular. It is just the issue in which after a while of use the app will stop filtering DNS traffic, even though the module is still toggled on. This is most likely why it does not show up in the logs.

@ghost
Copy link

ghost commented May 8, 2018

This is eerily similar to the issue I encountered in #748 . I’ve not run into this since the latest β release; it’s unfortunate others are, though it does certainly help in bug squashing. So for that I am grateful you both @kevandoyle2 & @rafuse for running into this.

@kevandoyle2
Copy link
Author

No problem at all, love the app.

Is there a reasonable eta you might have on a hotfix?

@zeezeepiggy
Copy link

Split Tunnel seems to be fine. The Full Tunnels have some weird issues when jumping to network... Still love the app. But i am in Split Tunnel for the time being since i always jump networks from cellular to wifi and vice versa.

@kathampy
Copy link

kathampy commented May 13, 2018

I have the same issue after that last update. Full-Tunnel Mode doesn’t work anymore on 4G. It only works on Wi-Fi. All apps show connection errors.

Even after disconnecting from Wi-Fi the icon remains on 1 bar and doesn’t switch to 4G.

@ghost
Copy link

ghost commented May 13, 2018

@kevandoyle2 , I was rereading the various posts & this caught my attention:

It is no advertisement or time in particular. It is just the issue in which after a while of use the app will stop filtering DNS traffic, even though the module is still toggled on. This is most likely why it does not show up in the logs.

If by “[stopping] filtering DNS traffic” you mean stopping all ad, tracking, etc. blocking, then this does actually differ from my own experience in the two previous releases in one important way. Yes, logging had stopped. My DNSCrypt server connection was interrupted, returning to using my iPhone’s default DNS servers. But never did any of AdGuard’s blocking capabilities stop functioning.

@kevandoyle2
Copy link
Author

kevandoyle2 commented May 14, 2018

@X8716e in your case, AG’s functionality remains in tact because either your device or yourself made the switch back to default DNS when the dnscrypt (or other encrypted dns) connection was interrupted. I never meant to say there was an issue with AG’s ad blocking capabilities, rather the way it handles the connection to my selected dns server. In my case, when that connection is interrupted (to dnscrypt), it would remain on dnscrypt until I manually restart the module or change dns servers. This is what I meant by stopping the filtering of dns traffic.

As a note, up to now I have only been having that issue with the full tunnel modes, not split tunnel. As far as I can tell, split tunnel works as intended, with a continuous connection to my selected dns server, even across cellular and WiFi networks.

@ghost
Copy link

ghost commented May 14, 2018

@kevandoyle2 , thank-you for the clarification.

@ghost
Copy link

ghost commented May 18, 2018

I don't want to be rude, but it's been almost 2 weeks now.. is this going to be fixed anytime soon?
I mean, people paid for the app and users are put to risk when such a basic function doesn't work as intended.

I really appreciate the effort of AdGuard team though!

@ameshkov
Copy link
Member

I suppose that the next beta build will cover most of the open high priority bugs at once, but we'd better verify it before publishing the update.

Do you mind signing up for the beta test?

@ghost
Copy link

ghost commented May 18, 2018

Do you mind signing up for the beta test?

If it helps, I'd be happy to sign up! Where do I have to do this?

@ghost
Copy link

ghost commented May 19, 2018

@zebrum
Copy link
Member

zebrum commented May 23, 2018

Guys! Who of you want to check if the problem was fixed? I need to know your apple_id to add you to a small beta test group. Contact me in Telegram (the same name as here) or write me an email to mg@adguard.com

@zebrum zebrum added this to the 2.1.1 milestone May 23, 2018
@Marco224
Copy link

hi guys, in my case AdGuard beta version 2.1.1 (158) did not solve the problem :(

@ameshkov
Copy link
Member

Could you please send the logs to devteam at adguard.com?

@Marco224
Copy link

Marco224 commented May 26, 2018

I have sent it, here is the video recording, the banner appears at the bottom of the screen.
User ID: 1148487

https://ufile.io/i7j5j

@bug-killer
Copy link

Archive.zip
The logs from @Marco224

@zebrum
Copy link
Member

zebrum commented May 28, 2018

@Marco224 post here a link to the app. Does the problem appear in other apps?

@Marco224
Copy link

The problem appears in all the apps. It is easy for me to reproduce it, just activate "wifi assistance" in settings-> cellular -> scroll down to the end -> activate "wifi assistance". This setting speeds up the transition between wifi and cellular network, so just go to an area where the wifi has a medium-low signal and use any app that requires internet data in daily use or in the steps between the various menus or pages. (I say this only to make the problem even more evident, actually it appears even if the wifi assistance is off).

the app that I used in the video is Newsify, just a rss reader, but then again, the ads appear in the same way in all the other apps, here the link:
https://itunes.apple.com/us/app/newsify-rss-reader/id510153374?mt=8

@Marco224
Copy link

Marco224 commented Jun 8, 2018

Hi guys I’m here again, it seems that the problem is not solved yet, I have tested the same app previously linked and here is the video using the new version 2.1.1 (161) and all privacy module suggestions enable:
https://ufile.io/cifvp

I did a quick test but it seems that as before, the ads appear in all the apps.
I have already sent the log file.
User ID: 1148487

@Marco224
Copy link

Marco224 commented Jun 8, 2018

Here is another video using google news app where at the end appears the ads. Normally it would be so:
img_4598

https://ufile.io/8hd0z

I have sent the log again

@IvanIin
Copy link
Contributor

IvanIin commented Jun 8, 2018

@Marco224
In the log to the firs video I see that system wide blocking works as it should. You can see the blocked domains in request log(to view it tap on dns requests statistics cell). Perhaps our filter does not contains the necessary domain names. You can try to block domains directly from request log. hello.lqm.io looks like an ads domain, try to block it first.

@Goddess-Bastet
Copy link

Good providing the ‘restart when network changes’ switch is off but as soon as you turn it on everything is blocked again.

@ameshkov
Copy link
Member

Good providing the ‘restart when network changes’ switch is off but as soon as you turn it on everything is blocked again.

What matters is that the default switch value is now "off". I doubt we can do anything with how it behaves when it's "on".

@Marco224
Copy link

In my case nothing has changed, it certainly happens much less than when the switch is on, but the problem is not solved. Ads that are blocked in the log continue to appear.

@Marco224
Copy link

However now when the switch is off now if imposed full-tunnel with VPN icon at the time of network change the AdGuard vpn no longer starts.
Here is the video: https://ufile.io/2gmdd

@zebrum
Copy link
Member

zebrum commented Jun 19, 2018

Hi @Marco224 ! Why is it 'ipad' on your video in top-left corner instead of the mobile carrier name when wi-fi is turned off?

Also can you record a video of what is happening on settings->general->VPN screen when VPN can't start?

@Marco224
Copy link

Marco224 commented Jun 19, 2018

The iPad inscription appears as I'm testing the app on a 5th generation iPad. It's much easier to make the problem appear by turning Wi-Fi on and off because the problem always occurs even when you turn off the "tunnel restart" switch.
During the change between Wi-Fi and mobile data deactivating the "tunnel restart" the problem appears 1 time out of 5 for this is more difficult to make a video or otherwise for me is negligible. If you want I can make a video also in that case.

WiFi on-off-on Full tunnel with vpn icon (log and vpn setting)
Here is the video on iPad 2017 iOS 11.4: https://ufile.io/3y2e9
Here is the video on iPhone 6s iOS 11.4: https://ufile.io/ufe4a

I would add that when (always in full-tunnel with vpn icon) the vpn icon does not appear after turning off and on Wi-Fi, not even the block of content on safari works more ...

@zebrum
Copy link
Member

zebrum commented Jun 19, 2018

@Marco224 I would appreciate if you catch the moment on video when VPN won't connect after switching from wi-fi to mobile. (settings->general->VPN screen is enough). And logs too apple at adguard.com

@Marco224
Copy link

I'm not sure what you mean I should do... what should I do on adguard.com? Sorry but my English is very bad... the problem only happens if you load any content that requires an internet connection while you change the connection, so this (the split screen on iPad) is the only way I have to show the settings on the vpn while loading a content. Unfortunately I don't have an iPad with mobile connection and I can't test the WiFi- Mobile data- WiFi step showing the settings on the vpn, and the split screen is not available on iPhone. I hope I have not misunderstood what you meant.
Here is the video: https://ufile.io/1mmzx

@zebrum
Copy link
Member

zebrum commented Jun 19, 2018

@Marco224 ok, I need you to reproduce the problem when filtering stops after switching from wi-fi to mobile and send logs to us, specify the exact time when issue happened.

@Marco224
Copy link

Marco224 commented Jun 19, 2018

I have sent the log, it happened at 01:12 during the switch WiFi-mobile on iPhone.
User ID: 1148487

If you want I can post the screen ad 1:12 with the ads.
Making a video by capturing exactly when it happens is impossible (in the case of WiFi - mobile data - WiFi), since it happens randomly using the phone. I am no longer able to reproduce the problem by myself (after deactivating the "tunnel restart"). Ads appear during a random connection change, so I do not attach a video. :)

In this case I watched some videos on YouTube and opened Newsify to read something before going to sleep...

@veronikasav
Copy link

User ID 1148487
Archive.zip

@Marco224
Copy link

Marco224 commented Jun 21, 2018

Hi! I sent yet another log where a different case occurred, in this case the vpn icon has not disappeared but the ads have appeared anyway while I’m on cellular data... in the log the ads are displayed in yellow and no longer in red (AppLovin, Amazon-adsystem...).🧐

As always I have the screen if you need

It happened at 8:46

@ghost
Copy link

ghost commented Jun 22, 2018

Version 2.1.1 with ‚Tunnel restart‘ enabled fixes the issue for me.
Full Tunnel Mode works fine now, network changes are not a problem anymore.

Thanks!

@zebrum zebrum modified the milestones: 2.1.1, 2.2.0 Jun 22, 2018
@Marco224
Copy link

Marco224 commented Jun 28, 2018

Hi guys! I'm back here :) I quickly tested the new build (166) and, in my case, I didn't notice any differences when the "Restart when network changes" switch is off: the problem is still there. But... I tried to reactivate the switch "Restart when network changes" it seems that the problem disappears both on iPad (WiFi on- WiFi off- WiFi on) and on iPhone (WiFi- cellular- WiFi). Ads that are red in the log are correctly blocked even during connection changes. 🤔 It's strange, but in my case, for now it simply works perfectly when the switch is on.

In any case, I do not want to rush to conclude; I will update you if I still have any problems. Good job!

@Marco224
Copy link

Marco224 commented Jul 1, 2018

Nothing to do, there was only a day after the update that seemed completely disappeared, now the problem always comes up again even with "restart when network changes" activated. In exactly the same way as before. I don't know how @rafuse managed to solve it.

@zebrum
Copy link
Member

zebrum commented Jul 12, 2018

@Marco224 there is one more guess about wi-fi assist option enabled. Can you try to disable it?

@Marco224
Copy link

I will try with the option disabled. I already tested AdGuard 2.1.1 with WiFi assistant disabled and it didn't change anything. I will let you know, although it does not seem a solution to the problem deactivate a useful system function

@Marco224
Copy link

I confirm that nothing changes, the only thing that changes is the distance from the wifi where the problem occurs, where the connection speed is obviously slower because it insists on using the wifi connection too weak because of the distance

@ameshkov ameshkov removed this from the 2.2.0 milestone Jul 22, 2018
@ameshkov
Copy link
Member

@drlivesey
Copy link

@ameshkov It is quite possible that renaming the app will help. Let's call it DnsGuard ;)
This way it will totally "use APIs and frameworks for their intended purposes..."
You developed a very nice and unique product! I hope you will be able to save it.

@Marco224
Copy link

I don't know if this can help, but if you think that there are so many apps on the Appstore that allow you to clear the iphone cache while not mentioning it at all in the description and preview of the app in the store. Despite this is not allowed by the policies of the store continue to be updated (because they do not mention it in descriptions or previews) and have always existed.
I know that this isn't probably your way of working... but in my opinion this is the only solution, rather than limiting such a well-made app.

@ameshkov
Copy link
Member

Too risky, we can easily lose the dev account if we try something like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests