Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System wide filters being reset #801

Closed
lancelot-moon opened this issue Jun 24, 2018 · 7 comments
Closed

System wide filters being reset #801

lancelot-moon opened this issue Jun 24, 2018 · 7 comments
Assignees
@IvanIin

Comments

@lancelot-moon
Copy link

lancelot-moon commented Jun 24, 2018 •
edited

https://youtu.be/vNp4Cxg44rw

Invalid ad blocking ever happened in the old version of AG Pro.
I met the issue again in AG Pro v2.1.1(165).

From the video, you can see that banner ads and pop-ups in the newspaper app were not blocked.
I checked DNS Requests Log.
Those domains in subscriptions showed "yellow" or "white" in DNS Requests Log.
Ex:
doubleclick.net
tktracker.aotter.net
tkmftc.aotter.net
flurry.com
They're in SDN filter, but they were not blocked.

Screenshots:

image

image


In DNS Requests Log, only domains in the blacklist would be noted by "red".
Ex:
I added graph.facebook.com in my blacklist.
graph.facebook.com was noted by red in DNS Requests Log.
But I tried to visit facebook.
It seems that browsing facebook was still normal even if blocking graph.facebook.com.
I was not sure if the blacklist really worked at that time.

Changing another DNS server in AG Pro or rebooting iPhone was unable to recover ad blocking.
Finally, after I clicked "Check for updates" for subscriptions, ad blocking was back.
(The situation is a little different with what I met before.
In the past, when I met invalid ad blocking, I tried to ever use real VPN (connect to real VPN once) for letting AG Pro's ad blocking back.
But this method was useless this time.)

When ad blocking of AG Pro was invalid, Disconnect Premium's ad blocking could normally work.
https://itunes.apple.com/us/app/disconnect-best-blocking-award/id935480186?ls=1&mt=8

I already sent the bug report to AdGuard Support at 19:42 on 24th June (GMT+8).
User ID: 1425202
Subject: [AdGuard Pro for iOS] 程式錯誤報告 (bug report)

iPhone 6 Plus
iOS v11.4
AG Pro v2.1.1(165), split VPN tunnel + general DNS server

Sorry that I don't have 100% reproduction steps.
I only can describe the process.
I idled my iPhone (no sim card) for several hours.
And then I enabled AG Pro's protection on iPhone but I found that I forgot to open Wi-Fi hotspot from my Android phone.
So I disabled AG Pro's protection.
After iPhone connected to the Wi-Fi hotspot from my Android phone, I enabled AG Pro's protection and found that ad blocking was invalid.

B/R
@Marco224
Copy link

Try to deactivate “tunnel restart” in advance settings. In my case it reduces the frequency of the problem even if it does not solve it.

@IvanIin IvanIin added this to the 2.1.2 milestone Jun 26, 2018
@IvanIin IvanIin self-assigned this Jun 26, 2018
@lancelot-moon
Copy link
Author

lancelot-moon commented Jun 28, 2018 •
edited

Hi,
The invalid ad blocking isn't solved in beta v2.1.2(166).
Even it became stranger because it seems that DNS Requests Log didn't catch all DNS requests when the bug occurred.
I ran an app with ads, but only 3 Apple's domains in DNS Requests Log.
Many other DNS requests disappeared.

Screenshot:

image


Comparison of the DNS Requests Log when ad blocking normally works.
Those ad domains should be shown by red in DNS Requests Log.

Screenshot:

image


Please watch the video.
https://youtu.be/FghtSvqrSso

I tried the app.
https://goo.gl/T8rNWq
In the past, I let AdGuard team add rules in filters for blocking ads in this app.
AdguardTeam/AdguardFilters#13171

But banner ads and pop-ups in the app were not blocked.

I idled my iPhone for several hours because of charging battery.
Before enabling AG Pro VPN, I deleted a domain from the blacklist.
After enabling AG Pro VPN, I found that ad blocking was invalid, and a lack of DNS requests in DNS Requests Log.

In beta v2.1.2(166), clicking "Check for updates" for subscriptions was unable to recover ad blocking.
I tried to ever use real VPN (connect to real VPN once) for letting AG Pro's ad blocking back.

I already sent the bug report to AdGuard Support at 15:33 on 28th June (GMT+8).
User ID: 1425202
Subject: [AdGuard Pro for iOS] 程式錯誤報告 (bug report)

Another thing:
Ivanlin, may you update translations when AG Pro v2.1.2 is released?
I had modified the translation of "Restart when network changes" on oneskyapp.
My new translation means "Restart tunnel when network changes".
Thanks.

B/R

@zebrum zebrum changed the title Ad blocking was invalid. System wide filters being reset Jun 28, 2018
@lancelot-moon
Copy link
Author

lancelot-moon commented Jun 28, 2018 •
edited

Why did "system wide filters being reset" cause a lack of DNS requests in DNS Requests Log?

When the bug happened, a lack of DNS requests in log occurred in beta v2.1.2(166), not in v2.1.1(165).

What did you change from v2.1.1(165) to beta v2.1.2(166)?

Or the modified title only explains about invalid ad blocking, right?

I just saw beta v2.1.2(167).
Do you only update AdGuard Assistant and translations in beta v2.1.2(167)?
( Specially thank you to update translations. m(_ _)m )
Other else for VPN tunnel?

Thanks.

@lancelot-moon
Copy link
Author

lancelot-moon commented Jul 4, 2018 •
edited

I idled my iPhone.
I removed a domain from the blacklist and then enabled AG Pro VPN.

Invalid adblock and a lack of DNS requests in DNS Requests Log appear in beta v2.1.2(167).

The same bug with beta v2.1.2(166).

Many other DNS requests didn't appear in DNS Requests Log.
It only showed some DNS requests.
So ads appeared in app.

Screenshot:

image


Split tunnel mode + general DNS

Please watch the video.
https://youtu.be/ua964FaqmpM

I already sent the bug report to AdGuard Support at 13:12 on 4th July (GMT+8).
User ID: 1425202
Subject: [AdGuard Pro for iOS] 程式錯誤報告 (bug report)

@lancelot-moon
Copy link
Author

lancelot-moon commented Jul 4, 2018 •
edited

@ameshkov

I just did some interesting experiments when the bug which was caused by AG Pro occurred.
Please watch the video.
https://youtu.be/ieyJL8Mdtxg

  1. When the bug which was caused by AG Pro occurred, adblock was still invalid even if I manually set AdGuard DNS as the system DNS in iOS Wi-Fi setting. (only Wi-Fi, no cellular network)

Disconnect Premium provides local VPN mode or real VPN mode with simple adblock.
(Disconnect focuses on trackers and malware.
It only blocks invasive ad domains.)

  1. With Disconnect Premium's local VPN, adblock was still invalid.

  2. With Disconnect Premium's real VPN, adblock was recovered.

AG Pro caused the bug, even changing system DNS is useless.
The abnormal situation would be latched & continued.
Only ever connecting to real VPN can dissolve the abnormal situation.

@zebrum
Copy link
Member

zebrum commented Jul 4, 2018

@lancelot-moon

Why did "system wide filters being reset" cause a lack of DNS requests in DNS Requests Log?

when there is an update of the subscriptions in the background mode while the internet connection is absent - they all being reset.

In your logs there is another problem: all requests are bypassed AdGuard in split mode
It may be related to #771 #772 tasks.

@IvanIin will check your logs and I'll create a new task if necessary.

@ameshkov ameshkov removed this from the 2.1.2 milestone Jul 22, 2018
@lancelot-moon
Copy link
Author

AG Pro beta v2.1.2(167)
I only use Wi-Fi, no cellular network.
I set AdGuard DNS as system DNS in Wi-Fi setting and chose AdGuard DNS in AG Pro for iOS.
But a lack of DNS requests and invalid Adblock function.

I recorded the video.
https://youtu.be/Rzx3P5N9S8E

I did an experiment.
After the VPN bug occurred, I tried AdGuard Pro, DNSCloak (with blacklist) and Disconnect Premium (local VPN, blocking mode).
Adblock function was all invalid.
Finally, I connected to real VPN for solving the latch.
https://youtu.be/BvrxCq-NpSk

I thought AdGuard team spent a lot of time on VPN-related bugs, but never actually solve it. Compared with wasting much time on finding which causes the VPN bugs, making the mechanism for unlocking the latch is simpler.
Then the users won't meet the issue.

I knew AG Pro is discontinued.
Just a record.
Know how...

adguard pushed a commit that referenced this issue Apr 16, 2020
@IvanIin
Merge pull request #801 in ADGUARD-IOS/adguard-ios from localizations…
f52ea75 
…/454 to master

* commit 'a9d17a3df02abd26e6720306b1bb6d0c227b8f5d':
  localizations update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IvanIin IvanIin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ameshkov @lancelot-moon @zebrum @IvanIin @Marco224