Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve content type detection using Sec-Fetch-Dest header #1382

Closed
ameshkov opened this issue Nov 22, 2020 · 0 comments
Closed

Improve content type detection using Sec-Fetch-Dest header #1382

ameshkov opened this issue Nov 22, 2020 · 0 comments

Comments

@ameshkov
Copy link
Member

We've already done it once, but I guess it's time to refresh the list of content types we're able to detect: https://www.w3.org/TR/fetch-metadata/#sec-fetch-dest-header

Additionally, we can now easily distinguish iframes (Chrome sends Sec-Fetch-Dest: iframe, we should also check Firefox and Safari), therefore we can make $subdocument work properly.

I am also interested in "Sec-Fetch-Mode" - it gives us the ability to distinguish main_frame and decide whether we don't need to use an intermediate blocking page for this case.

Question: what about xmlhttprequest? Can we detect it properly now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants