Provide an option to block request when it's opened in the main frame

[ameshkov]

Details:
AdguardTeam/AdguardForWindows#2043

Basically, we need to provide a "strict" level of blocking. When the strict level is enabled, we should block requests even when they're executed in the main browser frame.

Also, we'd better provide a modifier for blocking rules that will allow overriding the default behavior:
AdguardTeam/AdguardForWindows#2084 (comment)

The easiest way would be to allow $document modifier in the blacklist rules.

Also, add $all modifier:
https://github.com/gorhill/ublock/wiki/Static-filter-syntax#all

[FadeMind]

@ameshkov thanks for approving my idea. Regards

[ameshkov]

@FadeMind it makes perfect sense, thank you! Also, it's quite often when people ask us how to block this or that completely, and using $empty is not an ideal solution

[vshlobinag]

core/pull-requests/1482

[ameshkov]

There are some issues with the current implementation.

||exoclick.com^$document for some reason is applied instead of ||syndication.exoclick.com/splash.php?$empty,important,domain=dashishipin.com:

The second issue is that a $document rule is applied to a non-DOCUMENT response.

And finally, the third issue is that the $all rule, in this case, won't block non-document requests while it actually should.

[sxgunchenko]

core/pull-requests/1564

[AdamWr]

Regarding this issue - #152 (comment)

It seems that it happens again.

Steps to reproduce:

1. Add this rule:
   ||cda-tv.online^$document
2. Go here - https://cda-tv.online/filmy-online/malgosia-i-jas/ and click on "Proceed anyway" button
3. Click on one of the video players (marked on screenshot below).

Screenshot

Request marked as Other type is blocked.

Screenshot

[sxgunchenko]

It's not a regression since the actual request type detected by the filtering engine is xhr+document.
But there is an issue with the content type displaying which resides in the UI.

[AdamWr]

Ok, thank you for your answer.
Anyway, I'm wondering why $document must be applied in case like that?
Is there any real case where is needed to apply rule with $document modifier to request which is detected as xhr+document?

[adbuker]

@AdamWr, as for Adg4Win we'll improve content-type displaying soon - the corresponding task has been created