Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attribute display: none !important; is removed after few seconds #13

Closed
Alex-302 opened this issue Sep 1, 2016 · 5 comments
Closed

Attribute display: none !important; is removed after few seconds #13

Alex-302 opened this issue Sep 1, 2016 · 5 comments
Assignees
@theseanl
Labels
bug
Milestone
1.0.11

Comments

@Alex-302
Copy link
Member

Alex-302 commented Sep 1, 2016

Example link:
https://yandex.ru/pogoda/odessa/
Rules:

##.navigation-city_js_inited[-ext-has='a[onmousedown*="clck.yandex."]']
##.info__map[-ext-has='div[class]:contains(Яндекс.Директ)']
@Alex-302 Alex-302 added the bug label Sep 1, 2016
@ameshkov ameshkov changed the title Attribute display: none !important; removed after few seconds Attribute display: none !important; is removed after few seconds Sep 1, 2016
@Alex-302
Copy link
Member Author

Alex-302 commented Sep 5, 2016

The second example:
http://www.softpedia.com/
Rule:

softpedia.com#$#div[style^="font-size:"][style$="font-weight: 500;"][-ext-contains="Advertisement"] { position: absolute!important; left: -2000px!important; }

or

softpedia.com##div[style^="font-size:"][style$="font-weight: 500;"][-ext-contains="Advertisement"]
![image](http://imagizer.imageshack.com/img923/1633/gsXdTh.png)
While loading the rule works
![image](http://imagizer.imageshack.com/img924/7139/xZnpCV.png)
After loading custom attributes are reseted:
![image](http://imagizer.imageshack.com/img923/3478/xn6XeW.png)
CSS rule works as expected: 
##div[style^="font-size:"][style$="font-weight: 500;"]

@ameshkov ameshkov mentioned this issue Sep 14, 2016
Closed
@Alex-302
Copy link
Member Author

Another one #14

ameshkov added a commit that referenced this issue Oct 18, 2016
@ameshkov
https://github.com/AdguardTeam/ExtendedCss/issues/13
a368ab4
@ameshkov ameshkov mentioned this issue Oct 18, 2016
Merged
ameshkov added a commit that referenced this issue Oct 18, 2016
@ameshkov
https://github.com/AdguardTeam/ExtendedCss/issues/13
8409bc4
@ameshkov
Copy link
Member

Done

ameshkov added a commit that referenced this issue Mar 21, 2018
@ameshkov
Merge pull request #13 in EXTENSIONS/extended-css from feature/releas…
d6efaba 
…e_1.10 to master

* commit 'bd97519b9cc3cd87d5e31094bb173ef14e0e4699':
  Increment version
@theseanl
Copy link
Contributor

theseanl commented Apr 4, 2018

It is not working on 4pda.ru. Repro steps: add 4pda.ru##article.post:has(> .visual > a[title=Honor]) . The very first implementation had a flaw a368ab4#diff-1972c050c1317f95f4490c0e2e7313f2R55

@theseanl theseanl reopened this Apr 4, 2018
@theseanl theseanl self-assigned this Apr 4, 2018
@ameshkov ameshkov added this to the 1.0.11 milestone Apr 4, 2018
@ameshkov
Copy link
Member

ameshkov commented Apr 4, 2018

Assigned to 1.0.11 milestone.

theseanl pushed a commit that referenced this issue Apr 5, 2018
Merge pull request #14 in EXTENSIONS/extended-css from bug/issues/13#…
13de8bc 
…issuecomment-378521488 to master

* commit '392e427d53b708322c31e984c0c981aac71862f5':
  Fix
  Fix #13 (comment) 1. Fixed style protection, removed wasted attribute writes. 2. Completely removed all the ad hoc check whether selector is being debugged, changed it to follow proper interface method call.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theseanl theseanl

Labels
bug
Projects
None yet
Milestone
1.0.11
Development

No branches or pull requests
3 participants
@ameshkov @Alex-302 @theseanl