Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem about Japanese filter name. #562

Closed
SKEIDs opened this issue Jan 18, 2022 · 5 comments
Closed

Problem about Japanese filter name. #562

SKEIDs opened this issue Jan 18, 2022 · 5 comments

Comments

@SKEIDs
Copy link

SKEIDs commented Jan 18, 2022

I think the name is weird.
Please insert a space.

For example:

"filter.3.name": "AdGuard追跡防止フィルタ",

AdGuard追跡防止フィルタ → AdGuard 追跡防止フィルタ

@SKEIDs SKEIDs mentioned this issue Jan 18, 2022
@krystian3w
Copy link
Contributor

Looks strange for native speakers?

@gork7777
Copy link

Thanks, I'll look into the Japanese translation

@SKEIDs
Copy link
Author

SKEIDs commented Jan 19, 2022

Looks strange for native speakers?

The names of the other filters are fine if they don't have spaces.
However, most of them do have spaces.
I think it's better to align them.
I think that is the same as this↓

AdGuard Base → AdGuardBase

Isn't this strange?

@vyanovsky
Copy link

vyanovsky commented Jan 19, 2022

The idea was that maybe without the space is better because it's a name of the filter, "AdGuard Tracking Protection filter" = "AdGuard追跡防止フィルタ", like inseparable name/title.
The space it might separate them slightly, so one might think that it's combination of two semantics, "AdGuard" and "追跡防止フィルタ", not one solid filter name.

However, without the space it does look a bit strange visually.

Thank you for the feedback, we will think about which one is better, and correct all Japanese AdGuard filter names accordingly.
If you have any further thoughts, we'd be more than happy to hear them.

@SKEIDs
Copy link
Author

SKEIDs commented Jan 19, 2022

I understand. Thank you.

@SKEIDs SKEIDs closed this as completed Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants