[WIP] update header modifier compatibility #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ameshkov
requested changes
Sep 27, 2023
| @@ -445,9 +445,15 @@ The modifier `":" h_value` part may be omitted. In that case the modifier matche | |||
| * `@@||example.com^$header=set-cookie:/foo\, bar\$/` unblocks requests whose responses have the `Set-Cookie` header with value matching the `foo, bar$` regular expression. | |||
| * `@@||example.com^$header=set-cookie` unblocks requests whose responses have a `Set-Cookie` header with any value. | |||
|
|
|||
| :::caution Limitations | |||
|
|
|||
| In Adguard Browser Extension, [`$header`](#header-modifier) modifier is only compatible with [`$csp`](#csp-modifier) and [`$removeheader`](#removeheader-modifier) advanced modifiers. Rules that use [`$header`](#header-modifier) modifier with one of these, are subject to allowlisting logic of advanced modifiers. | |||
There was a problem hiding this comment.
We should explain the difference in matching logic of this modifier. It is matched only when headers are received so if the request was blocked or redirected on an earlier stage nothing will be applied. This logic is similar for both the browser extension and CoreLibs.
| :::info Compatibility | ||
|
|
||
| Rules with the `$header` modifier are supported by AdGuard for Windows, Mac, and Android, **running CoreLibs version 1.11 or later**. | ||
| Rules with the `$header` modifier are supported by AdGuard for Windows, Mac, and Android, **running CoreLibs version 1.11 or later**, and AdGuard Browser Extension, **running TSUrlFilter vX.X.X or later**. |
There was a problem hiding this comment.
This is waiting for an actual version num on tsurlfilter 2.2 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.