Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description for scriptlets exceptions #513

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

anyakushin
Copy link
Contributor

Target CoreLibs version is 1.16

@anyakushin anyakushin marked this pull request as ready for review June 20, 2024 10:21
@slavaleleka
Copy link
Contributor

take a look please at related Scriptlets repo changes:
AdguardTeam/Scriptlets@a711e27

@anyakushin
Copy link
Contributor Author

@slavaleleka what definitely to look at? I think its quite the same except the structure and syntax format

@slavaleleka
Copy link
Contributor

except the structure and syntax format

yes, syntax format is important because there is no difference (except the rule marker with and without @) now for blocking and exception syntax:

rule = [domains] "#%#//scriptlet(" scriptletName arguments ")"
rule = [domains] "#@%#//scriptlet(" scriptletName arguments ")"

also current kb section Syntax describes only blocking syntax:
https://uploads.adguard.org/sl5rr6yTS0XoD9iKXP.png

it could be more explicit and precise:
https://uploads.adguard.org/sl7EWzddeRqXte7z6u.png

@anyakushin
Copy link
Contributor Author

also current kb section Syntax describes only blocking syntax

It is the same for entire KB, isn't it? Exclusions syntax is mentioned only in Exclusions section that is on the same level as Syntax section. I can make it like it is in scriptlets repo, just wanna be sure that this will not interferee with current KB sections structure

Co-authored-by: Helen <58733007+el-termikael@users.noreply.github.com>
Copy link
Member

@ameshkov ameshkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add n note about versions of CoreLibs / AdGuard extension where we support this.

anyakushin and others added 2 commits July 19, 2024 10:03
Co-authored-by: Slava <45171506+slavaleleka@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants