You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If I'm not wrong, the problem is not related to redirect resource itself, but rather to the way how it's build.
It looks like that after script is compiled/built, then some methods are missed, in this case there is slicedToArray missed.
Steps to reproduce:
Use latest nightly build which use latest version of googletagservices-gpt redirect resource
There is an error - gpt.js:1 Uncaught ReferenceError: slicedToArray is not defined
Screenshot
The same happens with test like this:
test('Test updateTargetingFromMap',(assert)=>{runRedirect(name);assert.ok(window.googletag,'window.googletag have been created');assert.strictEqual(typeofwindow.googletag.defineSlot(),'object','Slot has been mocked');constoptDiv=3;constslot=window.googletag.defineSlot('1',2,optDiv);slot.updateTargetingFromMap({color: 'red',interests: ['sports'],});assert.strictEqual(slot.getTargeting('interests')[0],'sports','.getTargeting() has been mocked.');assert.strictEqual(window.hit,'FIRED','hit function was executed');});
adguard-bot
changed the title
Fix 'googletagservices-gpt' — 'updateTargetingFromMap'
Fix 'googletagservices-gpt' — updateTargetingFromMap()
May 16, 2023
Squashed commit of the following:
commit b7f12a4
Author: Adam Wróblewski <adam@adguard.com>
Date: Wed May 17 16:27:11 2023 +0200
Use hasOwnProperty() method instead of hasOwn()
commit 10e7098
Author: Adam Wróblewski <adam@adguard.com>
Date: Wed May 17 16:08:08 2023 +0200
Fix issue with updateTargetingFromMap() method in googletagservices-gpt redirect resource
Fix issue with sandbox attribute
If I'm not wrong, the problem is not related to redirect resource itself, but rather to the way how it's build.
It looks like that after script is compiled/built, then some methods are missed, in this case there is
slicedToArray
missed.Steps to reproduce:
googletagservices-gpt
redirect resourceAdGuard Tracking Protection filter
There is an error -
gpt.js:1 Uncaught ReferenceError: slicedToArray is not defined
Screenshot
The same happens with test like this:
Screenshot
It seems the problem is related to this line:
here:
Scriptlets/src/redirects/googletagservices-gpt.js
Lines 150 to 157 in b1e0bda
The text was updated successfully, but these errors were encountered: