Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve google-ima3 — add 'OmidVerificationVendor' property #353

Closed
AdamWr opened this issue Sep 1, 2023 · 0 comments
Closed

Improve google-ima3 — add 'OmidVerificationVendor' property #353

AdamWr opened this issue Sep 1, 2023 · 0 comments

Comments

@AdamWr
Copy link
Member

AdamWr commented Sep 1, 2023

Related to - AdguardTeam/AdguardFilters#160566
In this case rule like this:

||imasdk.googleapis.com/js/sdkloader/ima3.js$script,redirect=google-ima3,domain=kraloyun.com,important

causes that game does not work.

It seems that there are 2 issues.

First one - google.ima is missing OmidVerificationVendor - https://developers.google.com/interactive-media-ads/docs/sdks/html5/client-side/reference/js/google.ima#.OmidVerificationVendor
For example, something like this:

Code:
google.ima.OmidVerificationVendor = {
  "1": "OTHER",
  "2": "MOAT",
  "3": "DOUBLEVERIFY",
  "4": "INTEGRAL_AD_SCIENCE",
  "5": "PIXELATE",
  "6": "NIELSEN",
  "7": "COMSCORE",
  "8": "MEETRICS",
  "9": "GOOGLE",
  "COMSCORE": 7,
  "DOUBLEVERIFY": 3,
  "GOOGLE": 9,
  "INTEGRAL_AD_SCIENCE": 4,
  "MEETRICS": 8,
  "MOAT": 2,
  "NIELSEN": 6,
  "PIXELATE": 5,
  "OTHER": 1
};

should fixes it.

Second issue is that getInnerError returns undefined.

this.getInnerError = function () { };

But according to https://developers.google.com/interactive-media-ads/docs/sdks/html5/client-side/reference/js/google.ima.AdError#getInnerError it should returns null (or non-null Error) and it looks like that returning null fixes issue with loading game.

this.getInnerError = function () { return null; }; 
@slavaleleka slavaleleka added the enhancement Improvement of existent feature label Nov 2, 2023
@adguard-bot adguard-bot assigned slavaleleka and unassigned maximtop Nov 2, 2023
@adguard-bot adguard-bot changed the title Improve 'google-ima3' — OmidVerificationVendor Improve google-ima3 — OmidVerificationVendor Nov 2, 2023
adguard pushed a commit that referenced this issue Dec 21, 2023
Squashed commit of the following:

commit e75242a
Merge: 7169727 3e68841
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Tue Dec 19 16:24:14 2023 +0200

    Merge branch 'master' into fix/AG-25447

commit 7169727
Author: Adam Wróblewski <adam@adguard.com>
Date:   Tue Dec 19 14:26:12 2023 +0100

    Fix event listener binding in google-ima3 redirect
    Fix typo in getAdIsValue -> getAdIdValue
    Fix UniversalAdIdInfo

commit 27a339b
Author: Adam Wróblewski <adam@adguard.com>
Date:   Tue Dec 19 11:30:33 2023 +0100

    Improve AdDisplayContainer constructor in google-ima3
    Add div element to container

commit 112bd1d
Author: Adam Wróblewski <adam@adguard.com>
Date:   Wed Dec 13 10:31:50 2023 +0100

    Improve google-ima3
    Add OmidVerificationVendor object
    Fix getInnerError method, now it returns null
@adguard-bot adguard-bot changed the title Improve google-ima3 — OmidVerificationVendor Improve google-ima3 — add 'OmidVerificationVendor' property Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants