Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new scriptlet — 'json-prune-fetch-response' #361

Closed
slavaleleka opened this issue Sep 27, 2023 · 1 comment
Closed

Add new scriptlet — 'json-prune-fetch-response' #361

slavaleleka opened this issue Sep 27, 2023 · 1 comment
Assignees
@maximtop
Labels
Feature request Adding new feature Priority: P4 Release: v1.10.25 Resolution: Fixed Status: Closed Version: AdGuard v4.3.x patch 3 Version: Scriptlets v1.10

Comments

@slavaleleka
Copy link
Contributor

gorhill/uBlock@749cec0
adguard pushed a commit that referenced this issue Mar 1, 2024
@AdamWr
AG-26255 Add json-prune-fetch-response scriptlet. #361
cdeda86 
Squashed commit of the following:

commit 66fae36
Merge: 63c3a94 cc0f1fd
Author: Adam Wróblewski <adam@adguard.com>
Date:   Thu Feb 29 16:59:59 2024 +0100

    Merge branch 'master' into feature/AG-26255

commit 63c3a94
Author: Adam Wróblewski <adam@adguard.com>
Date:   Thu Feb 29 11:05:27 2024 +0100

    Refactor fetchHandlerWrapper function

commit 063876c
Author: Adam Wróblewski <adam@adguard.com>
Date:   Wed Feb 28 10:02:29 2024 +0100

    Update types
    Update example
    Update test

commit d97cfdc
Author: Adam Wróblewski <adam@adguard.com>
Date:   Tue Feb 27 19:53:34 2024 +0100

    Add json-prune-fetch-response scriptlet
@adguard-bot adguard-bot changed the title Add new scriptlet — json-prune-fetch-response Add new scriptlet — 'json-prune-fetch-response' Mar 28, 2024
This was referenced Apr 5, 2024
Closed
Closed
Closed
@Yuki2718
Copy link

Yuki2718 commented Apr 28, 2024 •
edited
Loading 

youtube.com##+js(json-prune-fetch-response, playerResponse.adPlacements playerResponse.playerAds playerResponse.adSlots adPlacements playerAds adSlots, , /playlist\?list=|player\?|watch\?v=/)

added to Base causes detection on uBO as uBO expects explicit propsToMatch like

www.youtube.com##+js(json-prune-fetch-response, playerResponse.adPlacements playerResponse.playerAds playerResponse.adSlots adPlacements playerAds adSlots, , propsToMatch, player?)

Unlike other compatibility issues I have reported, this can't trivially be fixed in FiltersCompiler because in AG implementation the position may not always be propsToMatch. Can you consider about this, as this will cause issues like this in the long run (regional lists maintainers may also suffer)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maximtop maximtop

Labels
Feature request Adding new feature Priority: P4 Release: v1.10.25 Resolution: Fixed Status: Closed Version: AdGuard v4.3.x patch 3 Version: Scriptlets v1.10
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@maximtop @adguard-bot @slavaleleka @Yuki2718