Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix set-constant scriptlet — Maximum call stack size exceeded #373

Closed
AdamWr opened this issue Oct 26, 2023 · 0 comments
Closed

Fix set-constant scriptlet — Maximum call stack size exceeded #373

AdamWr opened this issue Oct 26, 2023 · 0 comments
Assignees
@maximtop
Labels
bug Something isn't working Priority: P4 Release: v1.9.91 Resolution: Fixed Status: Closed Version: Scriptlets v1.9

Comments

@AdamWr
Copy link
Member

AdamWr commented Oct 26, 2023 •
edited

Steps to reproduce:

  1. Add this rule:
example.org#%#//scriptlet("set-constant", "foo.bar.test.abc", "noopFunc")
  1. Go to - https://example.org/
  2. Run in console:
window.foo = {};
foo = {};
adguard pushed a commit that referenced this issue Oct 30, 2023
@AdamWr
AG-27143 Fix issue with setting values to wrong properties in set-con…
38df83c 
…stant scriptlet. #373

Squashed commit of the following:

commit b4fb774
Merge: 751872d 0605d92
Author: Adam Wróblewski <adam@adguard.com>
Date:   Fri Oct 27 15:41:18 2023 +0200

    Merge branch 'master' into fix/AG-27143

commit 751872d
Author: Adam Wróblewski <adam@adguard.com>
Date:   Fri Oct 27 07:42:15 2023 +0200

    Update tests
    Remove global properties after tests

commit d1a58f9
Author: Adam Wróblewski <adam@adguard.com>
Date:   Thu Oct 26 21:28:05 2023 +0200

    Fix issue with setting values to wrong properties in set-constant scriptlet
@slavaleleka slavaleleka added the bug Something isn't working label Oct 31, 2023
This was referenced Nov 23, 2023
Closed
Closed
@adguard-bot adguard-bot mentioned this issue Dec 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maximtop maximtop

Labels
bug Something isn't working Priority: P4 Release: v1.9.91 Resolution: Fixed Status: Closed Version: Scriptlets v1.9
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@maximtop @AdamWr @adguard-bot @slavaleleka