Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve set-cookie — add more supported values #375

Closed
peace2000 opened this issue Oct 30, 2023 · 1 comment
Closed

Improve set-cookie — add more supported values #375

peace2000 opened this issue Oct 30, 2023 · 1 comment
Assignees
@slavaleleka
Labels
enhancement Improvement of existent feature Priority: P4 Release: v1.9.91 Resolution: Fixed Status: Closed Version: Scriptlets v1.9

Comments

@peace2000
Copy link

peace2000 commented Oct 30, 2023 •
edited

More values were added to uBO as accepted values gorhill/uBlock@d51b393. Can you add them to AG as well?

Added values were:
rejected
allowed
disallow
accepted
notaccepted
enable
enabled
disable
disabled
@adguard-bot adguard-bot changed the title New values to set-cookie Improve set-cookie — add more supported values Oct 31, 2023
@adguard-bot adguard-bot assigned slavaleleka and unassigned maximtop Oct 31, 2023
@slavaleleka
Copy link
Contributor

support "on" and "off"

Used on praxisplan.at.

uBlockOrigin/uAssets@0cd4612

(Also made a proposal to add them to uBO as well)

originally reported in #366

@slavaleleka slavaleleka added the enhancement Improvement of existent feature label Oct 31, 2023
adguard pushed a commit that referenced this issue Nov 1, 2023
@AdamWr
AG-27226 Improve set-cookie — add more supported values. #375
02e3e4e 
Squashed commit of the following:

commit 4691d95
Merge: 8823108 eace811
Author: Adam Wróblewski <adam@adguard.com>
Date:   Wed Nov 1 12:40:39 2023 +0100

    Merge branch 'master' into fix/AG-27226

commit 8823108
Author: Adam Wróblewski <adam@adguard.com>
Date:   Wed Nov 1 10:49:42 2023 +0100

    Update changelog

commit 04f6e78
Author: Adam Wróblewski <adam@adguard.com>
Date:   Tue Oct 31 18:39:23 2023 +0100

    Add new values to set-cookie scriptlet
    `on`, `off`, `accepted`, `notaccepted`, `rejected`, `allowed`, `disallow`, `enable`, `enabled`, `disable`, `disabled`
This was referenced Nov 23, 2023
Closed
Closed
@adguard-bot adguard-bot mentioned this issue Dec 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slavaleleka slavaleleka

Labels
enhancement Improvement of existent feature Priority: P4 Release: v1.9.91 Resolution: Fixed Status: Closed Version: Scriptlets v1.9
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@peace2000 @maximtop @adguard-bot @slavaleleka