Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'set-cookie' — do not encode a cookie name #408

Closed
Alex-302 opened this issue Feb 23, 2024 · 0 comments
Closed

Fix 'set-cookie' — do not encode a cookie name #408

Alex-302 opened this issue Feb 23, 2024 · 0 comments
Assignees
@slavaleleka
Labels
bug Something isn't working Priority: P4 Release: v1.10.25 Resolution: Fixed Status: Closed Version: AdGuard v4.3.x patch 3 Version: Scriptlets v1.10

Comments

@Alex-302
Copy link
Member

Alex-302 commented Feb 23, 2024 •
edited

Same as here, probably forgot about non-truste scriptlet
#311

example.com#%#//scriptlet('set-cookie', 'aa::bb::cc', '1')
image

trusted-set-cookie does not break a cookie name
example.com#%#//scriptlet('trusted-set-cookie', 'aa::bb::cc', '1')
image
@Alex-302 Alex-302 added the bug Something isn't working label Feb 23, 2024
@adguard-bot adguard-bot changed the title 'set-cookie' breaks a cookie name by encoding a name Fix 'set-cookie' — encode a cookie name Mar 11, 2024
@adguard-bot adguard-bot changed the title Fix 'set-cookie' — encode a cookie name Fix 'set-cookie' — do not encode a cookie name Mar 11, 2024
adguard pushed a commit that referenced this issue Mar 12, 2024
@slavaleleka
do not encode the name by cookie setting scriptlets. #408 AG-30675
69afa13 
Squashed commit of the following:

commit 5aec9da
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Tue Mar 12 16:33:14 2024 +0200

    fix semicolon adding to cookie

commit fe93f26
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Tue Mar 12 14:14:33 2024 +0200

    update docs

commit 3dd988b
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Tue Mar 12 14:03:08 2024 +0200

    fix concatCookieNameValuePath()

commit 8e90258
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Tue Mar 12 13:45:07 2024 +0200

    update changelog

commit 2e334e4
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Tue Mar 12 13:45:00 2024 +0200

    add tests for concatCookieNameValuePath()

commit 74fe7d1
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Tue Mar 12 13:44:22 2024 +0200

    improve concatCookieNameValuePath()
This was referenced Apr 5, 2024
Open
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slavaleleka slavaleleka

Labels
bug Something isn't working Priority: P4 Release: v1.10.25 Resolution: Fixed Status: Closed Version: AdGuard v4.3.x patch 3 Version: Scriptlets v1.10
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Alex-302 @adguard-bot @slavaleleka