netutil: imp tests

AdguardTeam · Apr 1, 2024 · 33cce10 · 33cce10
1 parent e221b7e
commit 33cce10
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/netutil/reversed.go b/netutil/reversed.go
@@ -1,6 +1,7 @@
 package netutil
 
 import (
+	"math"
 	"net"
 	"net/netip"
 	"strconv"
@@ -402,7 +403,7 @@ func isV4ARPALabel(label string) (ok bool) {
 			val = val*10 + int(c-'0')
 		}
 
-		return val <= 255
+		return val <= math.MaxUint8
 	}
 }
 

diff --git a/netutil/reversed_test.go b/netutil/reversed_test.go
@@ -569,6 +569,11 @@ func TestExtractReversedAddr(t *testing.T) {
 		name:    "partial_v4",
 		domain:  ipv4NetRevGood,
 		wantErr: "",
+	}, {
+		want:    netip.PrefixFrom(testIPv4PartPref.Addr(), testIPv4PartPref.Bits()+8),
+		name:    "partial_v4_zero_label",
+		domain:  "0." + ipv4NetRevGood,
+		wantErr: "",
 	}, {
 		want:    testIPv4Pref,
 		name:    "whole_v4_within_domain",
@@ -582,7 +587,7 @@ func TestExtractReversedAddr(t *testing.T) {
 	}, {
 		want:    testIPv4PartPref,
 		name:    "partial_v4_within_domain",
-		domain:  "a." + ipv4NetRevGood,
+		domain:  "abc." + ipv4NetRevGood,
 		wantErr: "",
 	}, {
 		want:    testIPv4PartPref,
@@ -594,6 +599,11 @@ func TestExtractReversedAddr(t *testing.T) {
 		name:    "overflow_v4_within_domain",
 		domain:  "a.256." + ipv4NetRevGood,
 		wantErr: "",
+	}, {
+		want:    testIPv4PartPref,
+		name:    "partial_v4_leading_zero_label",
+		domain:  "05." + ipv4NetRevGood,
+		wantErr: "",
 	}, {
 		want:    emptyV4Pref,
 		name:    "empty_v4",