Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/refactor and tests of check #14

Merged
merged 14 commits into from
May 4, 2020

Conversation

hrodes
Copy link
Contributor

@hrodes hrodes commented Apr 26, 2020

closes #2
closes #3
closes #10
closes #11

@hrodes hrodes changed the title WIP feat/refactor and tests of check feat/refactor and tests of check May 3, 2020
@figuerascarlos
Copy link
Contributor

Just a few comments if you can squash WIP commits and remove unused commented code.

@hrodes hrodes force-pushed the feat/refactor-and-tests-of-check branch from e4d3137 to 0f4be44 Compare May 4, 2020 13:24
Copy link
Contributor

@figuerascarlos figuerascarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@figuerascarlos figuerascarlos merged commit ce2d17b into master May 4, 2020
@figuerascarlos figuerascarlos deleted the feat/refactor-and-tests-of-check branch May 4, 2020 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants