Fixes #53 #54
Merged
Fixes #53 #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrodes
requested changes
May 27, 2020
cmd/enval.go
Outdated
| for _, err := range errs { | ||
| { | ||
| ok = false | ||
| prettyPrintError(err) |
There was a problem hiding this comment.
the info was already printed. This must just exit 1 without printing as soon as one is not valid
pkg/manifestchecker/types.go
Outdated
| @@ -175,6 +175,20 @@ func (result *ToolValidationResult) NotParseableVersionOutputCommand(msg string) | |||
| return result | |||
| } | |||
|
|
|||
| func (result *ToolValidationResult) CheckErrors() []error { | |||
There was a problem hiding this comment.
this function should be just IsValid returning result.IsToolAvailable && result.IsVersionValid && result.IsCommandVersionOutputParseable
pkg/exerrors/extended_error.go
Outdated
| @@ -40,6 +40,8 @@ const ( | |||
| UnsupportedInputRawVersionEnvalErrorKind | |||
| FieldVersionKeyNotFoundEnvalErrorKind | |||
| InvalidCustomSpecsDirEnvalErrorKind | |||
| InvalidVersionErrorKind | |||
pkg/exerrors/extended_error.go
Outdated
| @@ -40,6 +40,8 @@ const ( | |||
| UnsupportedInputRawVersionEnvalErrorKind | |||
| FieldVersionKeyNotFoundEnvalErrorKind | |||
| InvalidCustomSpecsDirEnvalErrorKind | |||
| InvalidVersionErrorKind | |||
| CommandVersionOutputNonParseableErrorKind | |||
santiagoaldanondo
force-pushed
the
bugfix/exit-code
branch
2 times, most recently
from
e7c50ef
to
5267079
Compare
santiagoaldanondo
force-pushed
the
bugfix/exit-code
branch
from
5267079
to
27fafc5
Compare
hrodes
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.