Sanitizing language input #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a language is used with certain types of characters, it's possible that the translate functions break when they encounter the character.
Update the Azure Translate API calls with UTF-8
AdhocAdam
added a commit
that referenced
this pull request
Sep 29, 2019
* Include Whole Email notes (#133) Per @moverton28, the notes on how to use the $includeWholeEmail variable are incorrect which leads to confusion on this particular setting's use. * Fixing Type Projection issue (#137) This is to address #130 * More reporting flexibility for AML (#128) * More reporting flexibility for AML Further breaking out AML returned values to support custom org processes and reporting * Removing a tab Accidentally tab the version number in * More extensions Further breaking out extension support for AML * Azure Translation integration (#143) * Azure Translate #3 Incorrect diff again. * Azure Translate graphic Uploading to update readme around the feature * placeholder for translate Creating entry on readme for translation feature * Update README.md * Dynamic Analyst Assignment fix (#139) * Dynamic Analyst Assignment fix Incorrect variable is used * Removing property Property doesn't exist as incoming value is a string/guid not an object * Modifying Set-AssignedToPerSupportGroup design Investigating the Set-AssignedToPerSupportGroup functions reveals a flaw within how the switch was leveraged. * Updating select When using volume based criteria, the selection needs to be expanded to discard the count property. * Updating variable (#148) Original calls were heavily based on prior example calls. * Sanitizing language input (#149) * Sanitizing languages If a language is used with certain types of characters, it's possible that the translate functions break when they encounter the character. * update API call Update the Azure Translate API calls with UTF-8 * Updating notes Adding change log notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a language is used with certain types of characters, it's possible that the translate functions break when they encounter the character. To get around this, strings will be UTF-8 encoded similar to the very nature of the translate API.
Also introducing handling for a condition when the Detected Language scores identical confidence to the top Alternative Detected Language. In this case, there is a possibility that translation doesn't occur because the Detected Language is the default target language that was configured in the connector. Take the following example: