Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Five #401

Merged
merged 29 commits into from Dec 25, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
78dd38e
Code Factor, style and formatting. Pass #1 (#390)
AdhocAdam Aug 28, 2022
e674b7a
Revert "Code Factor, style and formatting. Pass 1 (#390)" (#392)
AdhocAdam Aug 28, 2022
58f9257
Code Factor, style and formatting. Pass 2 (#393)
AdhocAdam Aug 28, 2022
02397a7
Code Factor, style and formatting. Pass 3 (#394)
AdhocAdam Aug 28, 2022
8126798
codefactor, blank lines (#395)
AdhocAdam Aug 28, 2022
85f3858
PSScriptAnalyzer, use singular nouns (#399)
AdhocAdam Aug 30, 2022
2120846
Merge branch 'primary' into dev
AdhocAdam Aug 30, 2022
b60ee73
multiple keywords (#400)
AdhocAdam Sep 4, 2022
f878767
unused variables (#404)
AdhocAdam Sep 10, 2022
49c2337
variable scope, isMember (#405)
AdhocAdam Sep 10, 2022
c74222a
alias, missing parameter (#406)
AdhocAdam Sep 10, 2022
9da262b
usage, isVerifiedSig (#407)
AdhocAdam Sep 10, 2022
ea29b1e
scope modifier, using: (#408)
AdhocAdam Sep 11, 2022
412cfb9
incorrect variable (#409)
AdhocAdam Sep 12, 2022
dc4932f
Attachments, Update-WorkItem
alexaxb Sep 13, 2022
a35044f
Merge branch 'primary' into dev
AdhocAdam Sep 13, 2022
b5d63f3
Get-SCSMUserByEmailAddress cannot find mail addresses with a dash (#403)
alexaxb Sep 20, 2022
1d54a01
description for IPM.Note.SMIME.MultipartSigned (#413)
AdhocAdam Sep 27, 2022
d3642b9
Single Instance Pickers (#412)
AdhocAdam Sep 28, 2022
9b828a9
Update Contributors (#414)
AdhocAdam Sep 28, 2022
a856c60
Settings UI forms and icons (#417)
AdhocAdam Oct 15, 2022
2566804
move smlets import further up (#422)
AdhocAdam Nov 19, 2022
cb73e66
Total runtime logging (#423)
AdhocAdam Nov 20, 2022
79ced4b
Extended OAuth logging (#424)
alexaxb Nov 21, 2022
7fe3934
Add DisplayName to new workitems (#425)
alexaxb Nov 24, 2022
09eb86b
inline notes (#426)
AdhocAdam Dec 1, 2022
9bfdac0
regex test (#427)
AdhocAdam Dec 23, 2022
522230f
updating inline notes
AdhocAdam Dec 23, 2022
4f522e4
re-arrange start time variable
AdhocAdam Dec 23, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Binary file added FeatureScreenshots/multipleKeywords.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion ManagementPack/2016/SMLets.Exchange.Connector/Settings.mpx
Expand Up @@ -1500,7 +1500,7 @@
</DisplayString>
<DisplayString ElementID="SMLets.Exchange.Connector.MessageClassEnum.IPM.Note.SMIME.MultipartSigned">
<Name>IPM.Note.SMIME.MultipartSigned</Name>
<Description>A digitally email message</Description>
<Description>A digitally signed email message</Description>
</DisplayString>
<DisplayString ElementID="SMLets.Exchange.Connector.MessageClassEnum.IPM.Schedule.Meeting.Request">
<Name>IPM.Schedule.Meeting.Request</Name>
Expand Down
@@ -1,4 +1,4 @@
using System;
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
Expand All @@ -12,6 +12,7 @@
using Microsoft.EnterpriseManagement.ConnectorFramework;
using System.Xml;
using System.Globalization;
using Microsoft.EnterpriseManagement.UI.Extensions.Shared;

namespace SMLetsExchangeConnectorSettingsUI
{
Expand Down Expand Up @@ -1900,7 +1901,6 @@ public String AzureCognitiveServicesBoundaries
}
}


public ManagementPackProperty ACSIncidentSentimentDecExtension
{
get
Expand Down Expand Up @@ -2227,7 +2227,7 @@ public ManagementPackProperty AMLIncidentClassificationPredictionEnumExtension
{
get
{
return incidentAMLClassificationPredictionExtensionEnum; ;
return incidentAMLClassificationPredictionExtensionEnum;
}
set
{
Expand Down Expand Up @@ -3070,16 +3070,16 @@ internal AdminSettingWizardData(EnterpriseManagementObject emoAdminSetting)
catch { this.IsCiresonAnnouncementsEnabled = false; }

this.SCSMApprovedAnnouncers = emoAdminSetting[smletsExchangeConnectorSettingsClass, "SCSMApprovedAnnouncementUsers"].ToString();
try
{
this.SCSMApprovedGroupGUID = (Guid)emoAdminSetting[null, "SCSMApprovedAnnouncementGroupGUID"].Value;
EnterpriseManagementObject ScsmApprovedGroupEmoObject;
ScsmApprovedGroupEmoObject = (EnterpriseManagementObject)emg.EntityObjects.GetObject<EnterpriseManagementObject>(this.SCSMApprovedGroupGUID, ObjectQueryOptions.Default);
this.SCSMApprovedGroupDisplayName = "CURRENT ANNOUNCEMENT GROUP: " + ScsmApprovedGroupEmoObject.DisplayName;
}
catch
if (emoAdminSetting[smletsExchangeConnectorSettingsClass, "SCSMApprovedAnnouncementGroupGUID"].Value != null)
{
this.SCSMApprovedGroupDisplayName = "NO ANNOUNCEMENT GROUP DEFINED";
try
{
this.SCSMApprovedAnnouncementGroup = ConsoleContextHelper.Instance.GetInstance((Guid)emoAdminSetting[smletsExchangeConnectorSettingsClass, "SCSMApprovedAnnouncementGroupGUID"].Value);
}
catch
{
//"NO ANNOUNCEMENT GROUP DEFINED";
}
}

//SCOM Integration
Expand All @@ -3088,16 +3088,16 @@ internal AdminSettingWizardData(EnterpriseManagementObject emoAdminSetting)
this.SCOMServer = emoAdminSetting[smletsExchangeConnectorSettingsClass, "SCOMmgmtServer"].ToString();
this.AuthorizedSCOMApproverType = emoAdminSetting[smletsExchangeConnectorSettingsClass, "SCOMApprovedMemberType"].ToString();
this.AuthorizedSCOMUsers = emoAdminSetting[smletsExchangeConnectorSettingsClass, "SCOMApprovedUsers"].ToString();
try
{
this.SCOMApprovedGroupGUID = (Guid)emoAdminSetting[null, "SCOMApprovedGroupGUID"].Value;
EnterpriseManagementObject ScomApprovedGroupEmoObject;
ScomApprovedGroupEmoObject = (EnterpriseManagementObject)emg.EntityObjects.GetObject<EnterpriseManagementObject>(this.SCOMApprovedGroupGUID, ObjectQueryOptions.Default);
this.SCOMApprovedGroupDisplayName = "CURRENT APPROVED GROUP: " + ScomApprovedGroupEmoObject.DisplayName;
}
catch
if (emoAdminSetting[smletsExchangeConnectorSettingsClass, "SCOMApprovedGroupGUID"].Value != null)
{
this.SCOMApprovedGroupDisplayName = "NO SCOM GROUP DEFINED";
try
{
this.SCOMApprovedGroup = ConsoleContextHelper.Instance.GetInstance((Guid)emoAdminSetting[smletsExchangeConnectorSettingsClass, "SCOMApprovedGroupGUID"].Value);
}
catch
{
//"NO SCOM GROUP DEFINED";
}
}

//Artificial Intelligence - Cognitive Services
Expand Down Expand Up @@ -3200,7 +3200,6 @@ internal AdminSettingWizardData(EnterpriseManagementObject emoAdminSetting)
catch { }
try
{

if (irproperty.Id == (Guid)emoAdminSetting[smletsExchangeConnectorSettingsClass, "ACSSentimentScoreIncidentClassExtensionGUID"].Value)
{
this.ACSIncidentSentimentDecExtension = irproperty;
Expand Down Expand Up @@ -3286,7 +3285,6 @@ internal AdminSettingWizardData(EnterpriseManagementObject emoAdminSetting)
catch { }
try
{

if (srproperty.Id == (Guid)emoAdminSetting[smletsExchangeConnectorSettingsClass, "ACSSentimentScoreServiceRequestClassExtensionGUID"].Value)
{
this.ACSServiceRequestSentimentDecExtension = srproperty;
Expand Down Expand Up @@ -3600,7 +3598,6 @@ public override void AcceptChanges(WizardMode wizardMode)

}
}

//Use Custom Rules
emoAdminSetting[smletsExchangeConnectorSettingsClass, "UseCustomRules"].Value = this.UseCustomRules;

Expand Down Expand Up @@ -3688,7 +3685,6 @@ public override void AcceptChanges(WizardMode wizardMode)

}
}

//Keywords
emoAdminSetting[smletsExchangeConnectorSettingsClass, "SCSMKeywordFrom"].Value = this.KeywordFrom;
emoAdminSetting[smletsExchangeConnectorSettingsClass, "SCSMKeywordAcknowledge"].Value = this.KeywordAcknowledge;
Expand Down Expand Up @@ -3763,17 +3759,31 @@ public override void AcceptChanges(WizardMode wizardMode)
}
emoAdminSetting[smletsExchangeConnectorSettingsClass, "SCSMApprovedAnnouncementUsers"].Value = this.SCSMApprovedAnnouncers;
//if the Announcement group is set, don't null it
try { emoAdminSetting[smletsExchangeConnectorSettingsClass, "SCSMApprovedAnnouncementGroupGUID"].Value = this.SCSMApprovedAnnouncementGroup["Id"]; }
catch { }
if (this.SCSMApprovedAnnouncementGroup != null)
{
try { emoAdminSetting[smletsExchangeConnectorSettingsClass, "SCSMApprovedAnnouncementGroupGUID"].Value = this.SCSMApprovedAnnouncementGroup["Id"]; }
catch { }
}
else
{
emoAdminSetting[smletsExchangeConnectorSettingsClass, "SCSMApprovedAnnouncementGroupGUID"].Value = null;
}

//SCOM Integration
emoAdminSetting[smletsExchangeConnectorSettingsClass, "EnableSCOMIntegration"].Value = this.IsSCOMIntegrationEnabled;
emoAdminSetting[smletsExchangeConnectorSettingsClass, "SCOMmgmtServer"].Value = this.SCOMServer;
emoAdminSetting[smletsExchangeConnectorSettingsClass, "SCOMApprovedMemberType"].Value = this.AuthorizedSCOMApproverType;
emoAdminSetting[smletsExchangeConnectorSettingsClass, "SCOMApprovedUsers"].Value = this.AuthorizedSCOMUsers;
//if the SCOM approved group is set, don't null it
try { emoAdminSetting[smletsExchangeConnectorSettingsClass, "SCOMApprovedGroupGUID"].Value = this.SCOMApprovedGroup["Id"]; }
catch { }
if (this.SCOMApprovedGroup != null)
{
try { emoAdminSetting[smletsExchangeConnectorSettingsClass, "SCOMApprovedGroupGUID"].Value = this.SCOMApprovedGroup["Id"]; }
catch { }
}
else
{
emoAdminSetting[smletsExchangeConnectorSettingsClass, "SCOMApprovedGroupGUID"].Value = null;
}

//Artifical Intelligence - enabled/disabled
emoAdminSetting[smletsExchangeConnectorSettingsClass, "EnableArtificialIntelligence"].Value = this.IsArtificialIntelligenceEnabled;
Expand Down
Expand Up @@ -24,10 +24,12 @@ namespace SMLetsExchangeConnectorSettingsUI
{
internal class AdminTaskHandler : ConsoleCommand
{
/*
public AdminTaskHandler()
{

}
*/

public override void ExecuteCommand(IList<NavigationModelNodeBase> nodes, NavigationModelNodeTask task, ICollection<string> parameters)
{
Expand Down Expand Up @@ -95,6 +97,5 @@ From BaseManagedEntity
RequestViewRefresh();
}
}

}
}
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Expand Up @@ -14,7 +14,7 @@
<!-- Contributors -->
<TextBlock Margin="0,5,0,0" TextWrapping="Wrap" FontStyle="Italic" Text="SMLets Exchange Connector (PowerShell) Contributors" />
<TextBlock Margin="10,0" TextWrapping="Wrap" Text="Martin Blomgren, Tom Hendricks, Leigh Kilday, nradler2, Justin Workman, Brad Zima, bennyguk, Jan Schulz,
Peter Miklian, Daniel Polivka" />
Peter Miklian, Daniel Polivka, Alexander Axberg" />
<!-- Reviewers -->
<TextBlock Margin="0,5,0,0" TextWrapping="Wrap" FontStyle="Italic" Text="SMLets Exchange Connector (PowerShell) Reviewers" />
<TextBlock Margin="10,0" TextWrapping="Wrap" Text="Tom Hendricks, Brian Wiest" />
Expand Down
Expand Up @@ -20,7 +20,6 @@ namespace SMLetsExchangeConnectorSettingsUI
/// <summary>
/// Interaction logic for AboutForm.xaml
/// </summary>

public partial class AboutForm : WizardRegularPageBase
{
private AboutForm adminSettingWizardData = null;
Expand All @@ -32,16 +31,17 @@ public AboutForm(WizardData wizardData)
this.adminSettingWizardData = this.DataContext as AboutForm;
}

/*
private void WizardRegularPageBase_Loaded(object sender, RoutedEventArgs e)
{

}
*/

//take the URL defined in the WPF and open a browser to it
private void Hyperlink_RequestNavigate(object sender, System.Windows.Navigation.RequestNavigateEventArgs e)
{
System.Diagnostics.Process.Start(e.Uri.AbsoluteUri);
}

}
}
}
@@ -1,4 +1,4 @@
<wpfwiz:WizardRegularPageBase x:Class="SMLetsExchangeConnectorSettingsUI.AnnouncementsForm"
<wpfwiz:WizardRegularPageBase x:Class="SMLetsExchangeConnectorSettingsUI.AnnouncementsForm"
xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
xmlns:sys="clr-namespace:System;assembly=mscorlib"
Expand Down Expand Up @@ -55,7 +55,6 @@
<TextBox Height="50" x:Name="txtApprovedMember" Text="{Binding SCSMApprovedAnnouncers}" IsEnabled="{Binding ElementName=chkAnnouncementIntegration, Path=IsChecked}" TextWrapping="Wrap"/>
<Label Margin="0,0,0,0" Content="Select the AD group approved for creating Announcements" />
<Custom:SingleInstancePicker IsEnabled="{Binding ElementName=chkAnnouncementIntegration, Path=IsChecked}" Instance="{Binding SCSMApprovedAnnouncementGroup, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}" BaseClassId="E2386B9B-5364-E438-A317-93836B979C56" Margin="0,0,10,0" />
<Label Margin="0,0,0,0" Content="{Binding SCSMApprovedGroupDisplayName}" />
</StackPanel>
</Grid>
</wpfwiz:WizardRegularPageBase>
</wpfwiz:WizardRegularPageBase>
Expand Up @@ -20,7 +20,6 @@ namespace SMLetsExchangeConnectorSettingsUI
/// <summary>
/// Interaction logic for AnnouncementsForm.xaml
/// </summary>

public partial class AnnouncementsForm : WizardRegularPageBase
{
//1. Create a blank Instance of AdminSettingsWizardData called "settings"
Expand All @@ -40,10 +39,12 @@ public AnnouncementsForm(WizardData wizardData)
//enable Cireson specific controls if the MP is imported per the AdminSettingsWizardData
if (settings.IsCiresonPortalMPImported == false) { chkPostAnnouncementToCiresonPortal.IsEnabled = false; }
}


/*
private void WizardRegularPageBase_Loaded(object sender, RoutedEventArgs e)
{

}
*/
}
}
Expand Up @@ -26,7 +26,6 @@ namespace SMLetsExchangeConnectorSettingsUI
/// <summary>
/// Interaction logic for AzureCognitiveServices.xaml
/// </summary>

public partial class ArtificialIntelligence : WizardRegularPageBase
{
//1. Create a blank Instance of AdminSettingsWizardData called "settings"
Expand Down Expand Up @@ -110,10 +109,12 @@ public ArtificialIntelligence(WizardData wizardData)
catch { }
}

/*
private void WizardRegularPageBase_Loaded(object sender, RoutedEventArgs e)
{

}
*/

//take the URL defined in the WPF and open a browser to it
private void Hyperlink_RequestNavigate(object sender, System.Windows.Navigation.RequestNavigateEventArgs e)
Expand Down Expand Up @@ -228,4 +229,4 @@ public override void SaveState(SavePageEventArgs e)
if (acsBoundariesToAddStringArray != null) { settings.AzureCognitiveServicesBoundaries = ACSBoundariesXMLString; }
}
}
}
}
Expand Up @@ -20,7 +20,6 @@ namespace SMLetsExchangeConnectorSettingsUI
/// <summary>
/// Interaction logic for AzureSpeech.xaml
/// </summary>

public partial class AzureSpeech : WizardRegularPageBase
{
AdminSettingWizardData settings;
Expand All @@ -34,9 +33,11 @@ public AzureSpeech(WizardData wizardData)
this.adminSettingWizardData = this.DataContext as AzureSpeech;
}

/*
private void WizardRegularPageBase_Loaded(object sender, RoutedEventArgs e)
{

}
*/
}
}
Expand Up @@ -20,7 +20,6 @@ namespace SMLetsExchangeConnectorSettingsUI
/// <summary>
/// Interaction logic for AzureTranslate.xaml
/// </summary>

public partial class AzureTranslate : WizardRegularPageBase
{
AdminSettingWizardData settings;
Expand All @@ -34,9 +33,11 @@ public AzureTranslate(WizardData wizardData)
this.adminSettingWizardData = this.DataContext as AzureTranslate;
}

/*
private void WizardRegularPageBase_Loaded(object sender, RoutedEventArgs e)
{
}
*/
}
}
Expand Up @@ -20,7 +20,6 @@ namespace SMLetsExchangeConnectorSettingsUI
/// <summary>
/// Interaction logic for AzureTranslate.xaml
/// </summary>

public partial class AzureVision : WizardRegularPageBase
{
AdminSettingWizardData settings;
Expand All @@ -34,9 +33,11 @@ public AzureVision(WizardData wizardData)
this.adminSettingWizardData = this.DataContext as AzureVision;
}

/*
private void WizardRegularPageBase_Loaded(object sender, RoutedEventArgs e)
{
}
*/
}
}
Expand Up @@ -20,7 +20,6 @@ namespace SMLetsExchangeConnectorSettingsUI
/// <summary>
/// Interaction logic for SettingsUI.xaml
/// </summary>

public partial class CiresonIntegrationForm : WizardRegularPageBase
{
//1. Create a blank Instance of AdminSettingsWizardData called "settings"
Expand All @@ -41,9 +40,11 @@ public CiresonIntegrationForm(WizardData wizardData)
if (settings.IsCiresonPortalMPImported == false) { chkCiresonIntegration.IsEnabled = false; }
}

/*
private void WizardRegularPageBase_Loaded(object sender, RoutedEventArgs e)
{
}
*/
}
}
Expand Up @@ -24,7 +24,6 @@ namespace SMLetsExchangeConnectorSettingsUI
/// <summary>
/// Interaction logic for CustomRules.xaml
/// </summary>

public partial class CustomRules : WizardRegularPageBase
{
//1. Create a blank Instance of AdminSettingsWizardData called "settings"
Expand Down Expand Up @@ -65,10 +64,12 @@ public CustomRules(WizardData wizardData)
catch { }
}

/*
private void WizardRegularPageBase_Loaded(object sender, RoutedEventArgs e)
{

}
*/

//create a class so additional custom rule object can be created per row and later worked with as objects
public class AdditionalCustomRule
Expand Down Expand Up @@ -153,4 +154,4 @@ public override void SaveState(SavePageEventArgs e)
if (customRuleToAddStringArray != null) { settings.MultipleCustomRulesToAdd = customRuleToAddStringArray; }
}
}
}
}