Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ItemLevel Changes #206

Closed
wants to merge 1 commit into from
Closed

ItemLevel Changes #206

wants to merge 1 commit into from

Conversation

bthurlow
Copy link

Fix #195.
Advanced design based on pull 178.

Item Level Text can be set to 9 different positions through the configuration screen.

Upgrade Icon can be set to 9 different positions through the configuration screen.

Fix AdiAddons#195.
Advanced design based on pull 178.

Item Level Text can be set to 9 different positions through the configuration screen.

Upgrade Icon can be set to 9 different positions through the configuration screen.
@Alyred
Copy link

Alyred commented Sep 1, 2017

This works really well and should be integrated into the main branch. May need a little alignment/organization on the options page.

@p5hema2
Copy link
Contributor

p5hema2 commented Sep 1, 2017

Implemented in my own fork and tested on 7.3.

Works like a charm.

Pls Merge

@AcidWeb
Copy link
Contributor

AcidWeb commented Sep 19, 2017

I merged this changes to my ElvUI fork.

@DoubleHighC
Copy link

DoubleHighC commented Feb 14, 2018

Hey there!! Just found this post and the changes work perfect!

Thank you very much for that and it would be awsome if I would find those changes in the next update!

Thanky you again! :-)

@Alyred
Copy link

Alyred commented Jul 28, 2018

I've made a few minor updates to this pull for the BfA stat squish, some re-coloring and the like. I set the "blue" and "purple" colors in the InventoryItemLevels method to be more like the Blizzard Rare and Epic colors, respectively, but do think they may be a bit hard to read. It's late here though and my eyes are tired. I'm considering changing them to more of a shade of the Cyan and Pink colors that were originally in the list.

Happy to see any comments.

Sorry my line levels aren't exact, I've added some comments

I'm not sure if can attach or propose additional files in this pull (sorry, only an armchair/script coder and haven't used GitHUB much for actual WORK... ;) so here's my adjustments, at around line number 262 in modules/ItemLevel.lua:

local colors = {
-- { upper bound, r, g, b }
{ 45, 0.55, 0.55, 0.55 }, -- gray, formerly 150
{ 75, 1.00, 1.00, 1.00 }, -- white, 999
{ 105, 1.00, 0.00, 0.00 }, -- red, formerly 250
{ 135, 1.00, 1.00, 0.00 }, -- yellow, 350
{ 165, 0.00, 1.00, 0.00 }, -- green, 372
{ 195, 0.00, 1.00, 1.00 }, -- cyan, 385
{ 225, 0.0, 0.439, 0.867 }, -- blue, 397, { 206, 0.00, 0.80, 1.00 }
{ 265, 0.639, 0.208, 0.933 }, -- purple, 403, { 221, 1.00, 0.50, 1.00 }
{ 295, 1.00, 0.70, 0.00 }, -- orange, formerly 300
{ 325, 1.00, 0.75, 1.00 }, -- pink, 410
}

Additionally, I modified the "level ranges" method colors to the following values (around line 370):

local maxLevelRanges = {
[60] = { 50, 62 }, -- [60] = { 66, 92 },
[70] = { 80, 94 }, -- [70] = { 100, 164 },
[80] = { 95, 105 }, -- [80] = { 187, 284 },
[85] = { 106, 115 }, -- [85] = { 333, 416 },
[90] = { 116, 135 }, -- [90] = { 450, 616 },
[100] = { 135, 150 }, -- [100] = { 615, 735 },
[110] = { 190, 265 }, -- [110] = { 805, 905 },
[120] = { 290, 320 }, -- new for BfA... completely estimated.
}

Finally, I made a change to line 204 to set the max iLevel for the "minimum iLevel threshold to show" to 250.

@aleczk
Copy link

aleczk commented Aug 4, 2019

I really wish this option, isn't anyone going to accept this pull? I'm struggling with things like this.
image

@aleczk
Copy link

aleczk commented Oct 16, 2019

I didn't even remember I posted this. If anyone encounters this, the way to 'fix' atm is manually changing the location at the addons folder.
Interface\AddOns\AdiBags\modules\**ItemLevel.lua**

Change the line 104 from:
text:SetPoint("TOPLEFT", button, 3, -1)

to:
text:SetPoint("BOTTOMLEFT", button, 3, 1)

You can also change the numbers after 'button' to change the position in screen. I set my y axis to 1 so it doesn't look weird. It was by default -1 because it meant to be showed on top.

Now it looks like this.
image

(and it does NOT go back to default when the AdiBags update)

@Talyrius
Copy link
Contributor

Closed in favor of #496.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UpgradeIcon broken for bank
7 participants