Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numbers not showing on 'neutral' mobs #310

Closed
mspykerez opened this issue Sep 8, 2018 · 5 comments
Closed

Numbers not showing on 'neutral' mobs #310

mspykerez opened this issue Sep 8, 2018 · 5 comments
Assignees
Labels
bug

Comments

@mspykerez
Copy link

@mspykerez mspykerez commented Sep 8, 2018

Since BFA I notice that the addon is not working (not showing spell countdowns for debuffs on target) at all on mobs that are neutral (can't be attacked) and then become hostile (most common encounter on role playing scenarios where a mob is talking and then starts attacking you).

Happens on my Balance druid spells moonfire and sunfire.

@nickdekruijk

This comment has been minimized.

Copy link

@nickdekruijk nickdekruijk commented Sep 8, 2018

I have the same issue! Also balance druid with moon-/sunfire. Maybe worth noting I'm using elvui. Haven't tried without that yet.

@Rainrider Rainrider self-assigned this Sep 9, 2018
@Rainrider Rainrider added the bug label Sep 9, 2018
@Rainrider

This comment has been minimized.

Copy link
Member

@Rainrider Rainrider commented Sep 9, 2018

This is probably again due to the way I try to guess the unit's reaction in order to resolve dynamic units like enemy and ally. I'll take a look

@mspykerez

This comment has been minimized.

Copy link
Author

@mspykerez mspykerez commented Sep 9, 2018

It happens on dungeons bosses too where they appear as neutral then become enemy. I notice however that during an encounter if the boss goes under the surface and becomes untarget when he appears again as a enemy everything works fine. So it appears that something wrong happens in the 'transition' between neutral to enemy target.

@Rainrider

This comment has been minimized.

Copy link
Member

@Rainrider Rainrider commented Sep 9, 2018

Yes, I need to update dynamic units when the unit's reaction changes. I think I have a solution, but have to test it. A way for now would be to untarget the mob and target it again (I think).

Do you know a mob where I can test this? I don't have a max level char yet and not needing a group would be nice.

@nickdekruijk

This comment has been minimized.

Copy link

@nickdekruijk nickdekruijk commented Sep 9, 2018

2nd boss freehold (turtle/shark) for example. But that would require a group ofc.
There are also some quest mobs you need to talk too and then become hostile. And also I remember seeing a rare in Drustvar. That would be the perfect testing mob if only I could remember which one it exactly was

@Rainrider Rainrider closed this in 0676a6c Sep 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.