Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sample example for valve module as well as seek and flush queue features #2

Conversation

SatwikSShanbhag
Copy link

@SatwikSShanbhag SatwikSShanbhag commented May 20, 2024

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes Apra-Labs#233

Description
PR contains two samples which uses three features of main Apra Pipes

valve Module
flush all queues
seek
Sample 1. creates Thumbnail using Valve module.
The pipeline reads MP4 video using Mp4ReaderSource Module and sends H264 encoded frames to H264Decoder Module then it send YUV420 encoded frames to valve module from valve module it take only one frame (1st frame) and send it to ColorConversion module where YUV420 frame gets converted to RGB raw frame then its sent to JPEGEncoderNVJPEG to covert it to jpg image and then sent to FileWriterModule to write the file.

Sample 2. start video from beginning using flush all queues and seek features
The pipeline reads MP4 video using Mp4ReaderSource Module and sends H264 encoded frames to H264Decoder Module then it send YUV420 encoded frames to ColorConversion module where YUV420 frame gets converted to RGB raw frame and then given to ImageViewerModule to render on screen after starting pipeline I am calling flushAllQueuesAndSeek function to restart video from beginning.

Precise description of the changes in this pull request

Alternative(s) considered

Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type

Type Choose one: (Bug fix | Feature | Documentation | Testing | Other)

Screenshots (if applicable)

Checklist

  • I have read the Contribution Guidelines
  • I have written Unit Tests
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach

@SatwikSShanbhag SatwikSShanbhag changed the title Ss/sample example sample example for valve module as well as seek and flush queue features Jun 3, 2024
Copy link

@mraduldubey mraduldubey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed thumbnail sample - go throught the comments and make similar changes in other samples. This is good work apart from the comments I have made.

Copy link

@mraduldubey mraduldubey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are files related to timelapse delteted. change the cerr to cout, rest is ok

@AdityaKBhadragond14 AdityaKBhadragond14 merged commit 7f79097 into AdityaKBhadragond14:ab/timelapse_sample Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants