Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Member "change history" generates warning #1516

Closed
Rvice opened this issue Nov 3, 2023 · 4 comments
Closed

Member "change history" generates warning #1516

Rvice opened this issue Nov 3, 2023 · 4 comments
Assignees
Milestone

Comments

@Rvice
Copy link
Contributor

Rvice commented Nov 3, 2023

Describe the bug
Updating from 4.2.12 to 4.2.13 resulted in an error when reviewing the change history in the members area.

To Reproduce
Steps to reproduce the behavior:

  1. Go to "Members"
  2. Click on "Change History" button
  3. Observe header notice (the is the local path on the Linux machine that is hosting the site)
    Notice: Undefined index: on in <serverRoot>/admidio/adm_program/system/classes/ProfileFields.php on line 301
    
    Warning: Cannot modify header information - headers already sent by (output started at 
    <serverRoot>/admidio/adm_program/system/classes/ProfileFields.php:301) in 
    <serverRoot>/admidio/adm_program/system/classes/HtmlPage.php on line 410
    

Expected behavior
I expect not to see this warning/notice

Screenshots

System (please complete the following information):

  • Admidio-Version 4.2.13
  • PHP 7.4.10
  • Database MySQL 5.6.51-91.0-log
  • Browser Chrome
  • Browser-Version Version 119.0.6045.105 (Official Build) (64-bit)

Additional context

@Fasse
Copy link
Member

Fasse commented Nov 4, 2023

I could not reproduce that error. This is not because of the update.

Could it be that you have changed or deleted a value of a DropDown or RadioButton field within the profile field configuration?

@Fasse Fasse added this to the v4.2.14 milestone Nov 4, 2023
@Fasse Fasse self-assigned this Nov 4, 2023
@Fasse
Copy link
Member

Fasse commented Nov 4, 2023

We will now show "Deleted entry" if there was an entry assigned that is now deleted.

@Fasse Fasse closed this as completed Nov 4, 2023
@Rvice
Copy link
Contributor Author

Rvice commented Nov 6, 2023

That resolved the error. Looks like "Deleted entry" is now showing as the new value of Marital Status and the previous value was blank... I believe in this case, the previous value was Married. Then the person created an account that "wiped out" marital status.

I tried testing this, but couldn't succeed.

Is there a way to see what the value was in the history? Or why it would result in the "deleted entry"?

@Rvice
Copy link
Contributor Author

Rvice commented Nov 9, 2023

I think I found the issue. I've crashed Playground with this user profile:

https://www.admidio.org/playground/adm_program/modules/profile/profile.php?user_uuid=565ca2dd-4618-4cba-9ce2-4865f50abed9

Note, I added "marital status" and there's a value I put in as "N/A"

I then had it set to default to N/A. Note, on initial setup of Marital STatus, it did not allow default of N/A, but editing after it did.

When I registered the user, I did not set a value. As a result, it would default to N/A.

I assume this is an issue of the '/' character in the values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants