New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recipient placeholder in email wrapper #1297
Recipient placeholder in email wrapper #1297
Conversation
As we send it to each receipient as a single mail we are using the TO Field as receipient and do not need to handle BCC/TO.
Could you please explain, why you remove the preferences with the option to add the recipients to BCC and set the count for it? |
Sure, because we are sending ever email on its one, the receiver will always be alone in the "TO" field, so no need to move them to BCC. Hope this makes sense? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we need this preferences. Some hosters don't allow to send many emails in a short time slot. Therefore we have the preferences to send one email to several recipients.
That was the problem why we don't had these placeholders. But if we want these placeholders, we could only use them if we send one email to one recipient. Maybe these placeholders will only be used if the preference is set to 1.
Makes sense to me. |
Hmm, that could be an option. But if you don't want to add a new preference it should also work for me if the check is for preference set to 1. Than we could also set the default for new installations to 1 or to single. |
I have now added it to the preferences. I would say it makes more sense to add it to the preferences and make a good description, because the "Multiple Recipients" and "Number of Recipients" have no effect after that. |
@@ -513,6 +513,24 @@ function getPreferencePanel($group, $id, $parentId, $title, $icon, $body) | |||
$formValues['mail_sendmail_name'], | |||
array('maxLength' => 50, 'helpTextIdInline' => 'SYS_SENDER_NAME_DESC') | |||
); | |||
|
|||
// Add js to show or hide mail options | |||
$page->addJavascript(' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if this is the best place to add it or if there is any "default" js how to handle things like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
until now we have no default to handle things like this. But a default could be useful :-)
@@ -513,6 +513,24 @@ function getPreferencePanel($group, $id, $parentId, $title, $icon, $body) | |||
$formValues['mail_sendmail_name'], | |||
array('maxLength' => 50, 'helpTextIdInline' => 'SYS_SENDER_NAME_DESC') | |||
); | |||
|
|||
// Add js to show or hide mail options | |||
$page->addJavascript(' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
until now we have no default to handle things like this. But a default could be useful :-)
@marchorst Thanks for this great new feature. With the release of version 4.2 I will update the doku with the new available parameters. |
The new params are not yet part of the doku. Had to search forever to find this ticket here. |
This new parameters are not part of the templates. They can be used within the concrete email you want to write. There we have documented them within the email dialog. |
With this change you are able to use the following placeholders within the email wrapper.
'#receiver_first_name#'
'#receiver_firstname#'
'#receiver_surname#'
'#receiver_lastname#'
'#receiver_email#'
'#receiver_name#'
It is also prepared to add more fields