-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor password #91
Conversation
Why do you create a new issue? This is also 89, an improved new hashing method :) I got the following error when using the branch:
We should not code so compact as in line 119. This is not easy to read and complicated to debug. Please write more lines and dont combine multiple method calls in one line. |
What do you mean with "Why do you create a new issue?" This isn't an issue. This is a pull request. I think i found the problem: https://stackoverflow.com/questions/13388541/php-parse-error-syntax-error-unexpected-t-object-operator/13388570#13388570 |
b68e7df should fix this |
Why are here conflicts and how can I solve them? I dont know how I can see these conflicts. I can to a branch merge to the master but then the Pull-Request is still open ... |
1f96f53
to
0462bfd
Compare
remove merge from master |
please review this code and give feedback