Added random latency to SQS receives. #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latency is based on the inclusion of two environment variables (GOAWS_RANDOM_LATENCY_MIN and GOAWS_RANDOM_LATENCY_MAX), which, if set will prevent messages from being released from the queue until after a period of random, simulated latency has elapsed. The purpose of this change is to aid in local testing against AWS when SQS latency is expected and needs to be developed against.
p4tin
requested changes
Sep 26, 2019
app/sqs.go
Outdated
| } | ||
|
|
||
| func getRandomLatency() (time.Duration, error){ | ||
| minVar := os.Getenv("GOAWS_RANDOM_LATENCY_MIN") |
There was a problem hiding this comment.
Sorry this took so long to evaluate but the values should be in the goaws.conf not in environment variables. This is for consistency sake with how all configs are done. thanks!
There was a problem hiding this comment.
@p4tin no worries, I've just pushed another commit - is this what you had in mind?
|
@p4tin does this PR look ok now? |
p4tin
approved these changes
Mar 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latency is based on the inclusion of two environment variables
(
GOAWS_RANDOM_LATENCY_MINandGOAWS_RANDOM_LATENCY_MAX), which, if setwill prevent messages from being released from the queue until after a
period of random, simulated latency has elapsed.
The purpose of this change is to aid in local testing against AWS when
SQS latency is expected and needs to be developed against.