Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to the properly maintained AUR package #433

Merged
merged 1 commit into from Sep 10, 2022
Merged

Switch to the properly maintained AUR package #433

merged 1 commit into from Sep 10, 2022

Conversation

xd003
Copy link
Contributor

@xd003 xd003 commented Sep 9, 2022

The package at https://aur.archlinux.org/packages/auto-cpufreq-git which has been linked in readme is out of date since long & is actually abondoned . https://aur.archlinux.org/packages/auto-cpufreq is the one being maintained properly at the moment

Also , at the time of writing this the auto-cpufreq-git package doesn't even compile anymore

@SunkenHero
Copy link
Contributor

SunkenHero commented Sep 9, 2022

At first, a little typo in your comment(First and second link are the same).
The compile error could be my fault because i recently made an pull request.
You can try to comment 1149-1151 in /auto-cpufreq/core.py out and then reinstall the package.

@AdnanHodzic
Copy link
Owner

AdnanHodzic commented Sep 10, 2022

I'm aware that AUR package has been abandoned (#388), and there are many bug reports about it and new ones like #434 coming in. But since I don't use Arch (based) distro I really have no interest in maintaining it as I'm too busy with other things.

@xd003 could you please make the changes proposed by @SunkenHero so we can merge this change. Thanks

@xd003
Copy link
Contributor Author

xd003 commented Sep 10, 2022

Just to update my findings , there's no error if i install auto-cpufreq manully using the installer script - https://github.com/AdnanHodzic/auto-cpufreq#auto-cpufreq-installer . So the issue seems to be somewhere within the auto-cpufreq-git package itself . So i would assume ideally changes need to be done in there & not really in this repo ? Here's the traceback just in case - https://www.klgrth.io/paste/onscc

@AdnanHodzic
Copy link
Owner

Just to update my findings , there's no error if i install auto-cpufreq manully using the installer script - https://github.com/AdnanHodzic/auto-cpufreq#auto-cpufreq-installer . So the issue seems to be somewhere within the auto-cpufreq-git package itself . So i would assume ideally changes need to be done in there & not really in this repo ? Here's the traceback just in case - https://www.klgrth.io/paste/onscc

Thanks for checking. Yes, in this case it's definitely problem which should be addressed on AUR package maintainers side.

@xd003
Copy link
Contributor Author

xd003 commented Sep 10, 2022

I am not really familiar with Arch Package builds , so i have mentioned in readme to use the binary package for releases & the Installer script if someone needs latest changes until the git package has a active maintainer

@SunkenHero
Copy link
Contributor

So i really got no idea how AUR packages work and what they really are, but your commit looks good and if it fixes the problem it would be good to get merged

@AdnanHodzic
Copy link
Owner

@xd003 one small change request from my side.

Could you please:

Set these 2 to be on the same line:

Binary Package (For the latest binary release on github)
Git Package(For the latest commits/changes )

Remove empty space before ,/. has issues . & maintaining it , and add . at the end of sentence here latest changes

@xd003
Copy link
Contributor Author

xd003 commented Sep 10, 2022

Looks good to me now

@AdnanHodzic
Copy link
Owner

Looks good to me now

Good stuff, thank you for your contribution and you'll be credited for you work as part of upcoming 1.9.6.

@AdnanHodzic AdnanHodzic merged commit ac0a4b5 into AdnanHodzic:master Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants