Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpufreqctl: don't try writing to non-existent files #533

Merged
merged 1 commit into from
Jul 1, 2023
Merged

cpufreqctl: don't try writing to non-existent files #533

merged 1 commit into from
Jul 1, 2023

Conversation

cmm
Copy link
Contributor

@cmm cmm commented Jun 30, 2023

When you give "nosmt" to your kernel, you still get directories under /sys that correspond to inactive hyperthreads, but there's nothing writable inside those directories, which causes auto-cpufreq to generate lots of logspam.

When you give "nosmt" to your kernel, you still get directories under
/sys that correspond to inactive hyperthreads, but there's nothing
writable inside those directories, which causes auto-cpufreq to
generate lots of logspam.
@AdnanHodzic
Copy link
Owner

Nice catch, not sure how this was missed until now. Thank you for your contribution, you will be credited for your work as part of future release.

@AdnanHodzic AdnanHodzic merged commit c67e290 into AdnanHodzic:master Jul 1, 2023
@cmm
Copy link
Contributor Author

cmm commented Jul 1, 2023

you will be credited for your work

I would rather not be, if it's all the same to you, having taken a closer look at the sources.

not sure how this was missed until now

Oh man. Many, many possible reasons. Where to even begin.

(I apologize if this comment sounds hostile. I do not mean it to! At this point I choose to believe that this whole project is an art performance, meant to show what's wrong with Linux user-space ecosystem in general and also how not to write software. Right?)

@AdnanHodzic
Copy link
Owner

you will be credited for your work

I would rather not be

Noted, you will not be credited.

if it's all the same to you, having taken a closer look at the sources.

Not sure what you mean by this.

(I apologize if this comment sounds hostile. I do not mean it to! At this point I choose to believe that this whole project is an art performance, meant to show what's wrong with Linux user-space ecosystem in general and also how not to write software. Right?)

I apologize if this comment sounds hostile. I do not mean it to!

Thanks for the heads up, because what follows definitely made it one of the most hostile and ill mannered comments :)

At this point I choose to believe that this whole project is an art performance, meant to show what's wrong with Linux user-space ecosystem in general and also how not to write software. Right?)

Needless to say, hours and hours of various contributors work, 4k stars on Github, 61 contributors, various mentions in reputable sites and news paper definitely don't agree with this statement.

If you think something is wrong, feel free to improve & fix it. Otherwise you're also free to stay away from this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants