"WIP" Create auto-cpufreq-sysvinit #599

AmerXz · 2023-11-12T13:49:58Z

Run Script (Could be replaceable by auto-cpufreq-r6 runscript )

And a sysvinit daemon for auto-cpufreq generated THANKS TO :-

https://github.com/yunginnanet/sysvinit-service-generator fork of https://github.com/wyhasany/sysvinit-service-generator

It should be inside /etc/init.d/

A sysvinit daemon for auto-cpufreq generated THANKS TO :- https://github.com/yunginnanet/sysvinit-service-generator fork of https://github.com/wyhasany/sysvinit-service-generator It should be inside /etc/init.d/

@AnasR7

Run script For auto-cpufreq That can make sysvinit recognise auto-cpufreq Note You can Also use the runscript inside auto-cpufreq/scripts/auto-cpufreq-s6 By @AnasR7 /run

AmerXz

Run script For auto-cpufreq That can make sysvinit recognise auto-cpufreq

Note You can Also use the runscript inside auto-cpufreq/scripts/auto-cpufreq-s6 By @AnasR7

AdnanHodzic · 2023-11-14T05:38:22Z

LGTM, but the part which I'm missing is how will the auto-cpufreq-installer detect if system user is running on is running on systemv and it's not refering to install script anywhre?

Or was there other you were envisioning of working?

shadeyg56

Thanks for this pr.

I do agree we should remove the auto-cpufreq-run since we already have the runfile in auto-cpufreq/scripts/auto-cpufreq-s6 to avoid redundancy and bloat

Also to repeat what Adnan suggested, the daemon installer script should be updated to include this new sysvinit service. The problem I see is what we already support openrc which uses sysvinit by default, so they both use the init process name for PID 1, so we need a way to distinguish the difference.

Something like this could work:

# snippet
elif [ "$(ps h -o comm 1)" = "init" ];then
    # Check if /etc/inittab file exists
    if [ -e "/etc/inittab" ]; then
       # sysvinit command here
    else
        # openrc stuff moved here
    fi

Additionally, the same change should be made to the daemon removal script. If that doesn't make sense, please let me know and also feel free to comment if you have any alternative ideas since I am not as familiar with openrc or sysvinit :)

shadeyg56 · 2023-11-14T20:17:32Z

scripts/auto-cpufreq-run

@@ -0,0 +1,3 @@
+!#/bin/bash


remove this file since we already have one like it

It's deleted

AmerXz · 2023-11-15T16:42:16Z

It's deleted

AdnanHodzic · 2023-11-16T19:20:30Z

It's deleted

👍, but this part is still missing:

Also to repeat what Adnan suggested, the daemon installer script should be updated to include this new sysvinit service. The problem I see is what we already support openrc which uses sysvinit by default, so they both use the init process name for PID 1, so we need a way to distinguish the difference.

Something like this could work:
# snippet
elif [ "$(ps h -o comm 1)" = "init" ];then
    # Check if /etc/inittab file exists
    if [ -e "/etc/inittab" ]; then
       # sysvinit command here
    else
        # openrc stuff moved here
    fi
Additionally, the same change should be made to the daemon removal script. If that doesn't make sense, please let me know and also feel free to comment if you have any alternative ideas since I am not as familiar with openrc or sysvinit :)

For reference see how in daemon installer script it was done for # Install script for openrc or # Install script for systemd and refer to @shadeyg56 comment above.

AmerXz · 2023-11-18T21:50:05Z

Sorry if I was late I want to take some time until I finish some few important things to do these days and I need to organize myself a little bit.

I will test my fork repository and will give you what happens then .

also thanks for these suggestions.

AdnanHodzic · 2023-11-19T06:09:38Z

No worries and take your time

AmerXz · 2023-11-22T06:29:52Z

# Install script for openrc / sysvinit
elif [ "$(ps h -o comm 1)" = "init" ];then
   mkdir /etc/inittab
    if [ -e "/etc/inittab" ]; then 
        echo -e "\n* Deploy auto-cpufreq sysvinit unit file"
        cp /usr/local/share/auto-cpufreq/scripts/auto-cpufreq-sysvinit /etc/init.d/auto-cpufreq
	
        echo -e "\n* "Reloading sysvinit manager configuration"
	service auto-cpufreq reload
 
        echo -e "\n* "Starting auto-cpufreq daemon (sysvinit) service"
        service auto-cpufreq start
        
        echo -e "\n* "Enabling auto-cpufreq daemon (sysvinit) service at boot"
	chkconfig auto-cpufreq-sysvinit on
      else
        echo -e "\n* Deploy auto-cpufreq openrc unit file"
        cp /usr/local/share/auto-cpufreq/scripts/auto-cpufreq-openrc /etc/init.d/auto-cpufreq
	echo -e "\n* "Starting auto-cpufreq daemon (openrc) service"
	rc-service auto-cpufreq start

	echo -e "\n* Enabling auto-cpufreq daemon (openrc) service at boot"
	rc-update add auto-cpufreqlocal/share/auto-cpufreq/scripts/auto-cpufreq-openrc /etc/init.d/auto-cpufreq

I Edited openrc script to be like that and I used this fedora resource in this link that helped me find sysvinit commands https://fedoraproject.org/wiki/SysVinit_to_Systemd_Cheatsheet

For now I didn't test the code

tell me for any suggestions if needed

I'll see you guys next time

shadeyg56 · 2023-11-22T06:38:26Z

I will test in a VM with both init systems

nixon87 · 2024-01-06T11:19:48Z

I am testing this right now on MX linux 23 Fluxbox 64 bit edition (non systemd) and would like to post my observations from discord (sry for the ad-hoc writing style):

Mh, it seems to work, installation went good, when i started in monitor mode it reminded me to de-install tlp, I did that restarted, now I'm running in live mode, the temperatures are the same with a different monitoring tool, unplugging the power supply gets detected, the setting to use governor is the same like in cat /sys/devices/system/cpu/cpu*/cpufreq/scaling_governor from another terminal. The testing laptop is fairly old: Not setting EPP (Not supported by system) Warning: CPU turbo is not available seem plausible.

However, I get "System has not been booted with systemd as init system (PID 1 ). Can't operate. Failed to connect to bus: PC is not active .... " when starting live or monitor mode, but I ignored that for now.

I see, I have to check if I get it installed permanently.

There seems to be a problem in line 84 at the auto-cpufreq-install script:

echo -e "\n* "Enabling auto-cpufreq daemon (sysvinit) service at boot"
chkconfig auto-cpufreq-sysvinit on

when running

sudo auto-cpufreq -- install

Turn off bluetooth on boot
Deploy auto-cpufreq install script

* Deplo auto-cpufreq*remove script

There was a problem, couldn't determine GNOME Power Profiles Daemon

-----------------Running auto-cpufreq daemon install script -------------------------
/usr/local/bin/auto-cpufreq-install: line 84: syntax error near unexpected token >> ( <<
/usr/local/bin/auto-cpufreq-install: line 84: echo -e "\n* "Enabling auto-cpufreq daemon (sysvinit) service at boot" '

--------------------- auto-cpufreq daemon installed and runnin--------------------------

....
I wrote the above by hand from another pc.

Thank you for your work on non-systemd compatibility . :)

nixon87 · 2024-01-08T11:28:13Z

Further investigating: there seems to be at least some trouble with the additional (") after "\n
from line 78 - 89

    echo -e "\n* "Reloading sysvinit manager configuration"
service auto-cpufreq reload

    echo -e "\n* "Starting auto-cpufreq daemon (sysvinit) service"
    service auto-cpufreq start

    echo -e "\n* "Enabling auto-cpufreq daemon (sysvinit) service at boot"
chkconfig auto-cpufreq-sysvinit on

and

      echo -e "\n* "Starting auto-cpufreq daemon (openrc) service"

nixon87 · 2024-01-08T12:00:01Z

After deleting the additional " the terminal output says it doesn't know chkconfig which doesn't seem to be used by mx linux fluxbox (not installed).

AmerXz · 2024-01-08T16:05:27Z

I'm downloding mx linux on a vm and test the code again , I'm sorry for not giving much time to this pull request .

AmerXz · 2024-01-10T12:57:49Z

Ok it seems that chkconfig command is deprecated years ago and we should use insteasd sysv-rc-conf it can be found in debian repos https://packages.debian.org/bookworm/sysv-rc-conf

source https://askubuntu.com/questions/221293/why-is-chkconfig-no-longer-available-in-ubuntu/277732#277732

nixon87 · 2024-01-10T16:01:01Z

Alrighty, there are some errors I want to post here besides chkconfig, you might have come across them in your virtual machine:

when running auto-cpufreq --install (with the changes from above)

I also get these three errors:

mkdir: cannot create folder : "/etc/inittab": file exists already

Reloading sysvinit manager configuration
auto-cpufreq: unrecognized service
starting auto-cpufreq daemon (ssvinit) service
auto-cpufreq: unrecognized service

Again, thanks for your work :)

applied some suggested fixes and replace (mkdir) command with (ls) and also replaced deprecated (chkconfig) command with (sysv-rc-conf) last but not least I need to have auto-cpufreq-sysvinit inside '/usr/local/share/auto-cpufreq/scripts/' for testing I tried to copy auto-cpufreq-sysvinit file to '/usr/local/share/auto-cpufreq/scripts/' manually to check if the install script will work and I had the output below ''' /etc/inittab * Deploy auto-cpufreq sysvinit unit file * Starting auto-cpufreq daemon (sysvinit) service * Enabling auto-cpufreq daemon (sysvinit) service at boot '''

nixon87 · 2024-01-11T22:27:50Z

scripts/auto-cpufreq-install.sh

-
-        echo -e "\n* "Reloading sysvinit manager configuration"
-	service auto-cpufreq reload
+        cp /usr/local/share/auto-cpufreq/scripts/auto-cpufreq-sysvinit /etc/init.d/auto-cpufreq



I think you need a
chmod +x /etc/init.d/auto-cpufreq
here
The copying to /etc/init.d works on my system but the script is not executable.
Maybe the same later for openrc.

nixon87 · 2024-01-12T07:45:20Z

Just for a heads up: as written in the review the copying when running auto-cpufreq --install seems to work now. When adding chmod +x /etc/init.d/auto-cpufreq and restart the os the shell script runs as a system service at reboot. But when running auto-cpufreq --stats the daemon doesn't seem to be active. I think it's close to working but sadly I am no expert at all. I guess the sysvinit script needs some revisit and maybe the things pointed out by shadeyg56 regarding the daemon removal script. Maybe shadeyg56 can take a look at the state right now?

AdnanHodzic · 2024-01-21T08:01:37Z

@shadeyg56 could you please take a final look and confirm if it's all working, if it's let's merge this. Thanks!

nixon87 · 2024-01-21T10:12:33Z

As written above I think it's not quite there yet, at least on my machine the auto-cpufreq daemon isn't active. The init system script gets started however (after the suggested changes).

shadeyg56 · 2024-01-21T23:12:30Z

Haven't been able to test in a VM since sudo auto-cpufreq --install does not work in VMs so the OS would need to be installed natively. @AmerXz have you tested the changes?

change SCRIPT to use runfile inside "/usr/local/share/auto-cpufreq/scripts/auto-cpufreq-s6/"

I forget that (sysvinit-service-generator I used earlier) had some small tutorial at the end of running script to make the service work so I replaced sysvinit daemon install section with commands inspired from that script and added commands to make the service and the run script inside auto-cpufreq-s6 to run as executables

@wyhasany

sysvinit-service-generator script aslo helped me know how to uninstall sysvinit service I added the commands that are inspired by these scripts I have to thank @wyhasany for making the script and @yunginnanet for his fork with the needed fixes otherwise I wouldn't be able to get auto-cpufreq-sysvinit to work

small Fix for small mistake

AmerXz

line 92 has extra "local/share/auto-cpufreq/scripts/auto-cpufreq-openrc /etc/init.d/auto-cpufreq" added there by mistake

This is fixed in the more updated commit

AmerXz · 2024-02-21T18:51:49Z

scripts/auto-cpufreq-install.sh

I have to thank @wyhasany for making the script and @yunginnanet for his fork with the needed fixes otherwise I wouldn't be able to get auto-cpufreq-sysvinit to work

I suggest you prepend "WIP" (work in progress) to title of this PR, and then please remove WIP part & announce it when it's ready for review.

Thanks!

Remove note needed code in line 78

AmerXz · 2024-03-31T18:38:50Z

I did some test to the code and it ran perfectly fine on mx-linux with sysvinit even after reboot , But I couldn't test it in openrc distro .

I tried to install artix with openrc but the installation was broken so I need another distro or maybe other iso version .

Create auto-cpufreq-sysvinit

46e7f19

A sysvinit daemon for auto-cpufreq generated THANKS TO :- https://github.com/yunginnanet/sysvinit-service-generator fork of https://github.com/wyhasany/sysvinit-service-generator It should be inside /etc/init.d/

AmerXz marked this pull request as ready for review November 12, 2023 13:50

Create auto-cpufreq-run

20f8c58

Run script For auto-cpufreq That can make sysvinit recognise auto-cpufreq Note You can Also use the runscript inside auto-cpufreq/scripts/auto-cpufreq-s6 By @AnasR7 /run

AmerXz commented Nov 12, 2023

View reviewed changes

AdnanHodzic requested a review from shadeyg56 November 14, 2023 05:39

shadeyg56 requested changes Nov 14, 2023

View reviewed changes

Delete scripts/auto-cpufreq-run

74d5c28

AmerXz added 2 commits November 22, 2023 09:32

Update auto-cpufreq-install.sh

5a97158

Merge branch 'AdnanHodzic:master' into patch-2

f67588e

nixon87 reviewed Jan 11, 2024

View reviewed changes

AmerXz added 2 commits February 4, 2024 22:49

Merge branch 'AdnanHodzic:master' into patch-2

a3bc063

Update auto-cpufreq-sysvinit

8bc2be0

change SCRIPT to use runfile inside "/usr/local/share/auto-cpufreq/scripts/auto-cpufreq-s6/"

AmerXz added 3 commits February 21, 2024 21:39

Update auto-cpufreq-install.sh

27a2f93

small Fix for small mistake

AmerXz commented Feb 21, 2024

View reviewed changes

AmerXz changed the title ~~Create auto-cpufreq-sysvinit~~ "WIP" Create auto-cpufreq-sysvinit Feb 23, 2024

AmerXz added 3 commits February 23, 2024 16:18

Merge branch 'AdnanHodzic:master' into patch-2

17b5ade

Merge branch 'AdnanHodzic:master' into patch-2

1d8ff2d

Update auto-cpufreq-install.sh

bf045bb

Remove note needed code in line 78

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

"WIP" Create auto-cpufreq-sysvinit #599

"WIP" Create auto-cpufreq-sysvinit #599

AmerXz commented Nov 12, 2023 •

edited

AmerXz left a comment

AdnanHodzic commented Nov 14, 2023

shadeyg56 left a comment •

edited

shadeyg56 Nov 14, 2023

AmerXz Nov 15, 2023

AmerXz commented Nov 15, 2023

AdnanHodzic commented Nov 16, 2023

AmerXz commented Nov 18, 2023

AdnanHodzic commented Nov 19, 2023

AmerXz commented Nov 22, 2023 •

edited

shadeyg56 commented Nov 22, 2023

nixon87 commented Jan 6, 2024 •

edited

nixon87 commented Jan 8, 2024 •

edited

nixon87 commented Jan 8, 2024

AmerXz commented Jan 8, 2024 •

edited

AmerXz commented Jan 10, 2024

nixon87 commented Jan 10, 2024 •

edited

nixon87 Jan 11, 2024 •

edited

nixon87 commented Jan 12, 2024 •

edited

AdnanHodzic commented Jan 21, 2024

nixon87 commented Jan 21, 2024

shadeyg56 commented Jan 21, 2024

AmerXz left a comment

AmerXz Feb 21, 2024

AdnanHodzic Feb 22, 2024

AmerXz commented Mar 31, 2024

"WIP" Create auto-cpufreq-sysvinit #599

Are you sure you want to change the base?

"WIP" Create auto-cpufreq-sysvinit #599

Conversation

AmerXz commented Nov 12, 2023 • edited

AmerXz left a comment

Choose a reason for hiding this comment

AdnanHodzic commented Nov 14, 2023

shadeyg56 left a comment • edited

Choose a reason for hiding this comment

shadeyg56 Nov 14, 2023

Choose a reason for hiding this comment

AmerXz Nov 15, 2023

Choose a reason for hiding this comment

AmerXz commented Nov 15, 2023

AdnanHodzic commented Nov 16, 2023

AmerXz commented Nov 18, 2023

AdnanHodzic commented Nov 19, 2023

AmerXz commented Nov 22, 2023 • edited

shadeyg56 commented Nov 22, 2023

nixon87 commented Jan 6, 2024 • edited

nixon87 commented Jan 8, 2024 • edited

nixon87 commented Jan 8, 2024

AmerXz commented Jan 8, 2024 • edited

AmerXz commented Jan 10, 2024

nixon87 commented Jan 10, 2024 • edited

nixon87 Jan 11, 2024 • edited

Choose a reason for hiding this comment

nixon87 commented Jan 12, 2024 • edited

AdnanHodzic commented Jan 21, 2024

nixon87 commented Jan 21, 2024

shadeyg56 commented Jan 21, 2024

AmerXz left a comment

Choose a reason for hiding this comment

AmerXz Feb 21, 2024

Choose a reason for hiding this comment

AdnanHodzic Feb 22, 2024

Choose a reason for hiding this comment

AmerXz commented Mar 31, 2024

AmerXz commented Nov 12, 2023 •

edited

shadeyg56 left a comment •

edited

AmerXz commented Nov 22, 2023 •

edited

nixon87 commented Jan 6, 2024 •

edited

nixon87 commented Jan 8, 2024 •

edited

AmerXz commented Jan 8, 2024 •

edited

nixon87 commented Jan 10, 2024 •

edited

nixon87 Jan 11, 2024 •

edited

nixon87 commented Jan 12, 2024 •

edited