Open source

[dkstevekwak]

No description provided.

[Jolg42]

This doesn't look like an appropriate license for demos 🤔

[macdonst]

@dkstevekwak the LICENSE file in the root of the PR is MIT and that looks good but the Adobe Confidential header seems wrong to me. This is sample code we want folks to use, I don't think we want to retain rights like that header suggests. I mean is says:

Dissemination of this information or reproduction of this material is strictly forbidden unless prior written permission is obtained from Adobe.

So that ain't right.

Is that what you meant @Jolg42?

[stevengill]

This PR looks good on first glance to me.

@Jolg42 the license is MIT. The source code header is more about adobe copyright rather than license. It is the standard one we use here at Adobe. It does feel a little heavy handed though.

[stevengill]

lol I see at @macdonst beat me to it. I'll check with Adobe lawyers about it. It feels too heavy for this case.

[macdonst]

@stevengill yeah, we should get some clarification and add it to the handbook. I really feel sample/demo code should be MIT while everything else we open source should be Apache-2.0.

[Jolg42]

+1 @macdonst and the new repo https://github.com/Adobe-CEP/Getting-Started-guides is Apache 2.0 which is a lot better.

[stevengill]

Alright, chatted with @macdonst and a few others and we agree. It is to heavy handed and not good for open source. The apache 2.0 header is great and simple. Most new OS requests at Adobe go Apache license. So we haven't really run into this problem much. But now that we are suggesting MIT for sample code, this header needs to be updated.

I've updated our internal handbook.

The new header should be

ADOBE CONFIDENTIAL

Copyright [first year code created] Adobe

All Rights Reserved.
NOTICE: Adobe permits you to use, modify, and distribute this file in
accordance with the terms of the Adobe license agreement accompanying
it. If you have received this file from a source other than Adobe,
then your use, modification, or distribution of it requires the prior
written permission of Adobe. 

[Jolg42]

Sounds good! 👍

[dkstevekwak]

@Jolg42 & @macdonst Thanks for your feedback and thanks @stevengill for providing a new template. I will replace the license headers tomorrow.

[dkstevekwak]

@bbb999 wanted to double check this change is fine. My editor was throwing an error since this is an extra else

[bbb999]

Thanks!

[dkstevekwak]

@bbb999 wanted to confirm with you this change is ok. I think it should be === instead of =? please correct me if I'm wrong