Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XSS Vulnerability in generic lists #1417

Closed
3 tasks
josephrignanese opened this issue Jul 6, 2018 · 0 comments
Closed
3 tasks

XSS Vulnerability in generic lists #1417

josephrignanese opened this issue Jul 6, 2018 · 0 comments
Milestone

Comments

@josephrignanese
Copy link
Contributor

Required Information

  • AEM Version, including Service Packs, Cumulative Fix Packs, etc: 6.3
  • ACS AEM Commons Version: 3.14.10
  • Reproducible on Latest? yes

Expected Behavior

When a generic list page or item contains html code it should be adequately encoded when rendered on the page to prevent an XSS attack

Actual Behavior

Content is rendered without escaping

Steps to Reproduce

Install ACS Commons
Create a new generic list page and enter the title as <script type="text/javascript">alert('1');</script>
Drag an ACS commons generic list item into the page and enter the title as <script type="text/javascript">alert('2');</script>. Enter the value as <script type="text/javascript">alert('3');</script>

When the page is opened observe that you are prompted with alerts 1, 2 and 3.

Links

acs-commons-genericlist-xss-test.zip

josephrignanese added a commit to josephrignanese/acs-aem-commons that referenced this issue Jul 6, 2018
@justinedelson justinedelson added this to the 3.17.2 milestone Jul 7, 2018
justinedelson added a commit that referenced this issue Jul 7, 2018
[bugfix #1417] Added XSS encoding for genericlist components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants